Merge lp:~kampka/ubuntu/quantal/fwknop/upstart-support into lp:ubuntu/quantal/fwknop
Proposed by
Christian Kampka
Status: | Merged | ||||
---|---|---|---|---|---|
Merge reported by: | Martin Pitt | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~kampka/ubuntu/quantal/fwknop/upstart-support | ||||
Merge into: | lp:ubuntu/quantal/fwknop | ||||
Diff against target: |
58 lines (+39/-0) (has conflicts) 2 files modified
debian/changelog (+9/-0) debian/fwknop-server.upstart (+30/-0) Text conflict in debian/changelog |
||||
To merge this branch: | bzr merge lp:~kampka/ubuntu/quantal/fwknop/upstart-support | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Dimitri John Ledkov | Approve | ||
James Page | Needs Fixing | ||
Oliver Grawert | Needs Information | ||
Ubuntu branches | Pending | ||
Review via email: mp+124683@code.launchpad.net |
Description of the change
The fwknop package can benefit greatly from upstart supervision.
First of it is generally deployed as a single point of failure with the side effect that a failing fwknopd will probably leave the machine unmanageable by eg. ssh. Second, the current 2.x release is fairly new and rewritten in another language (ported from Perl to C) and it's stability is not as proven as the older 1.x line.
Because of that, having upstart supervise the fwknopd process ("respawn") will provide at least ease of mind if not significantly reduce maintenance problems.
To post a comment you must log in.
there are several checks for additional configuration files in the sysvinit script (/etc/fwknop/ access. conf /etc/fwknop/ fwknopd. conf).
are these not used in 2.x anymore, does the daemon do the check itself now or will it just got into a crash/respawn loop if they are missing ?