Merge lp:~kamalmostafa/ubuntu/lucid/antennavis/fix-120923-crash into lp:ubuntu/lucid/antennavis

Proposed by Kamal Mostafa
Status: Merged
Merge reported by: Kamal Mostafa
Merged at revision: not available
Proposed branch: lp:~kamalmostafa/ubuntu/lucid/antennavis/fix-120923-crash
Merge into: lp:ubuntu/lucid/antennavis
Diff against target: 45 lines (+15/-1)
3 files modified
debian/changelog (+6/-0)
debian/control (+2/-1)
pcard.c (+7/-0)
To merge this branch: bzr merge lp:~kamalmostafa/ubuntu/lucid/antennavis/fix-120923-crash
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+19255@code.launchpad.net
To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2009-10-30 20:39:37 +0000
3+++ debian/changelog 2010-02-13 04:37:13 +0000
4@@ -1,3 +1,9 @@
5+antennavis (0.3-6ubuntu1) lucid; urgency=low
6+
7+ * Fix segfault crash when no loading a file with no GW lines. (LP: #120923)
8+
9+ -- Kamal Mostafa <kamal@whence.com> Fri, 12 Feb 2010 19:40:14 -0800
10+
11 antennavis (0.3-6) unstable; urgency=low
12
13 * Retiring - set the package maintainer to Debian QA Group.
14
15=== modified file 'debian/control'
16--- debian/control 2009-10-30 20:39:37 +0000
17+++ debian/control 2010-02-13 04:37:13 +0000
18@@ -1,7 +1,8 @@
19 Source: antennavis
20 Section: hamradio
21 Priority: optional
22-Maintainer: Debian QA Group <packages@qa.debian.org>
23+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
24+XSBC-Original-Maintainer: Debian QA Group <packages@qa.debian.org>
25 Build-Depends: debhelper (>= 5.0.0), tcl8.4-dev, tk8.4-dev, libgl1-mesa-dev | libgl-dev, libglu1-mesa-dev | libglu-dev, libxmu-dev
26 Standards-Version: 3.7.2
27
28
29=== modified file 'pcard.c'
30--- pcard.c 2006-06-23 21:31:11 +0000
31+++ pcard.c 2010-02-13 04:37:13 +0000
32@@ -564,6 +564,13 @@
33 } /** For each card **/
34 fclose(fin);
35
36+ /** Check whether we read any tubes at all before proceeding. **/
37+ if ( antData->first_tube == NULL ) {
38+ fprintf(stderr, "No geometry tubes (GW lines) specified in file %s\n",
39+ file_name);
40+ return;
41+ }
42+
43 /** Traverse list of elements to find dynamic range **/
44 /** We will need to scale things to accomodate all **/
45 /** sizes of antennas. **/

Subscribers

People subscribed via source and target branches

to all changes: