~kamalb/charm-logrotated:reschedule-cron-daily

Last commit made on 2023-01-06
Get this branch:
git clone -b reschedule-cron-daily https://git.launchpad.net/~kamalb/charm-logrotated
Only Kamal Bhaskar can upload to this branch. If you are Kamal Bhaskar please log in for upload directions.

Branch merges

Branch information

Name:
reschedule-cron-daily
Repository:
lp:~kamalb/charm-logrotated

Recent commits

216f7ea... by Kamal Bhaskar

Reschedule cron.daily jobs to non-default/random timings

e045383... by Mert Kirpici

Close LP #1969157

Reviewed-on: https://code.launchpad.net/~mertkirpici/charm-logrotated/+git/charm-logrotated/+merge/433371
Reviewed-by: Erhan Sunar <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Ramesh Sattaru <email address hidden>

49f6e8f... by Mert Kirpici

tox: pin flake8<6.0.0

flake8-import-order plugin and the new flake8 release are not playing
well, pinning for the time being

Signed-off-by: Mert Kırpıcı <email address hidden>

f833b4b... by Mert Kirpici

lib_logrotate: compile rotate regex pattern

Signed-off-by: Mert Kırpıcı <email address hidden>

7b74fd3... by Mert Kirpici

tests/unit: add meaningful logfile names

Signed-off-by: Mert Kırpıcı <email address hidden>

f6afc3c... by Mert Kirpici

chore: drop support for xenial, bionic

Signed-off-by: Mert Kırpıcı <email address hidden>

7a7f658... by Mert Kirpici

chore: fix linting issues

Signed-off-by: Mert Kırpıcı <email address hidden>

794db73... by Mert Kirpici

lib_logrotate: do not let postrotate fool us

Checking for the existence of "rotate" string inside a logrotate entry
used to fool the logic into believing a retention period is defined if
only "postrotate" is defined,
however causing re.sub() call to fail silently, causing a no-op.

We are using re.findall() instead of a substring check now. Also there
are two new unit tests for this condition now.

Works-on: 1969157
Signed-off-by: Mert Kırpıcı <email address hidden>

4b54183... by Tianqi Xiao

Modify pytest fixture to resolve bug LP#1983398

Reviewed-on: https://code.launchpad.net/~txiao/charm-logrotated/+git/charm-logrotated/+merge/427993
Reviewed-by: Eric Chen <email address hidden>

f1ea1dc... by Tianqi Xiao

Modify pytest fixture to resolve bug LP#1983398