Merge lp:~kalikiana/ubuntu-ui-toolkit/demoThinDivider into lp:ubuntu-ui-toolkit/staging

Proposed by Cris Dywan
Status: Merged
Approved by: Zsombor Egri
Approved revision: 1026
Merged at revision: 1031
Proposed branch: lp:~kalikiana/ubuntu-ui-toolkit/demoThinDivider
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 31 lines (+21/-0)
1 file modified
examples/ubuntu-ui-toolkit-gallery/ListItems.qml (+21/-0)
To merge this branch: bzr merge lp:~kalikiana/ubuntu-ui-toolkit/demoThinDivider
Reviewer Review Type Date Requested Status
Zsombor Egri Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+217432@code.launchpad.net

Commit message

Add a section for the ThinDivider to the gallery

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1026
http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/113/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-trusty-touch/465
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/5090
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-trusty-amd64-ci/113
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-trusty-armhf-ci/113
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-trusty-armhf-ci/113/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-trusty-i386-ci/113
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/415
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4725
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/4725/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/6457
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/4377
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/5285
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/5285/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sdk-team-ubuntu-ui-toolkit-staging-ci/113/rebuild

review: Approve (continuous-integration)
Revision history for this message
Zsombor Egri (zsombi) wrote :

We have plenty of dividers in that page, but yeah, nothing that would explicitly show that. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/ubuntu-ui-toolkit-gallery/ListItems.qml'
2--- examples/ubuntu-ui-toolkit-gallery/ListItems.qml 2014-04-23 09:39:11 +0000
3+++ examples/ubuntu-ui-toolkit-gallery/ListItems.qml 2014-04-28 13:02:35 +0000
4@@ -48,6 +48,27 @@
5 }
6 }
7
8+ TemplateSection {
9+ title: i18n.tr("ThinDivider")
10+ className: "ThinDivider"
11+
12+ Column {
13+ anchors.left: parent.left
14+ anchors.right: parent.right
15+
16+ ListItem.Standard {
17+ text: i18n.tr("Label")
18+ showDivider: false
19+ }
20+ ListItem.ThinDivider {
21+ }
22+ ListItem.Standard {
23+ text: i18n.tr("Label")
24+ showDivider: false
25+ }
26+ }
27+ }
28+
29 ListItemsSection {
30 title: i18n.tr("Progression")
31 className: "Standard"

Subscribers

People subscribed via source and target branches