Merge lp:~kalikiana/ubuntu-ui-toolkit/demoIcons into lp:ubuntu-ui-toolkit/staging
- demoIcons
- Merge into staging
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Tim Peeters | ||||
Approved revision: | 1031 | ||||
Merged at revision: | 1050 | ||||
Proposed branch: | lp:~kalikiana/ubuntu-ui-toolkit/demoIcons | ||||
Merge into: | lp:ubuntu-ui-toolkit/staging | ||||
Diff against target: |
80 lines (+53/-0) 2 files modified
debian/control (+1/-0) examples/ubuntu-ui-toolkit-gallery/Icons.qml (+52/-0) |
||||
To merge this branch: | bzr merge lp:~kalikiana/ubuntu-ui-toolkit/demoIcons | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Approve | |
Tim Peeters | Approve | ||
Review via email: mp+217433@code.launchpad.net |
Commit message
Add a Theme section to the Icon section in the gallery
Description of the change
Tim Peeters (tpeeters) wrote : | # |
Tim Peeters (tpeeters) wrote : | # |
can we fill the model automatically with the list of available icons?
Tim Peeters (tpeeters) wrote : | # |
Great, very useful :)
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1026
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1028
http://
Executed test runs:
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
Cris Dywan (kalikiana) wrote : | # |
FTR autopilot.
Cris Dywan (kalikiana) wrote : | # |
Can't reproduce the failure.
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1029
http://
Executed test runs:
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
- 1030. By Cris Dywan
-
Gallery now uses Qt.labs.
folderlistmodel
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1030
http://
Executed test runs:
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:1031
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
Preview Diff
1 | === modified file 'debian/control' |
2 | --- debian/control 2014-05-05 07:42:47 +0000 |
3 | +++ debian/control 2014-05-12 09:34:29 +0000 |
4 | @@ -111,6 +111,7 @@ |
5 | qtdeclarative5-ubuntu-ui-toolkit-plugin, |
6 | ubuntu-ui-toolkit-theme, |
7 | qtdeclarative5-xmllistmodel-plugin, |
8 | + qml-module-qt-labs-folderlistmodel, |
9 | ${misc:Depends}, |
10 | ${shlibs:Depends} |
11 | Recommends: libqt5multimedia5-plugins, ubuntu-ui-toolkit-doc |
12 | |
13 | === modified file 'examples/ubuntu-ui-toolkit-gallery/Icons.qml' |
14 | --- examples/ubuntu-ui-toolkit-gallery/Icons.qml 2014-04-23 09:39:11 +0000 |
15 | +++ examples/ubuntu-ui-toolkit-gallery/Icons.qml 2014-05-12 09:34:29 +0000 |
16 | @@ -16,6 +16,9 @@ |
17 | |
18 | import QtQuick 2.0 |
19 | import Ubuntu.Components 0.1 |
20 | +import Ubuntu.Components.ListItems 0.1 as ListItem |
21 | +import Ubuntu.Components.Popups 1.0 |
22 | +import Qt.labs.folderlistmodel 2.1 |
23 | |
24 | Template { |
25 | objectName: "iconsTemplate" |
26 | @@ -74,5 +77,54 @@ |
27 | height: 24 |
28 | } |
29 | } |
30 | + |
31 | + TemplateRow { |
32 | + title: i18n.tr("Theme") |
33 | + spacing: units.gu(2) |
34 | + |
35 | + |
36 | + Flow { |
37 | + anchors.fill: parent |
38 | + spacing: units.gu(2) |
39 | + |
40 | + Repeater { |
41 | + model: FolderListModel { |
42 | + folder: "/usr/share/icons/ubuntu-mobile/actions/scalable" |
43 | + showDirs: false |
44 | + showOnlyReadable : true |
45 | + sortField: FolderListModel.Name |
46 | + nameFilters: [ "*.svg" ] |
47 | + } |
48 | + Icon { |
49 | + id: themedIcon |
50 | + name: fileBaseName || "" |
51 | + width: 24 |
52 | + height: 24 |
53 | + MouseArea { |
54 | + anchors.fill: parent |
55 | + onClicked: PopupUtils.open(iconPop, themedIcon, { 'icon': themedIcon.name }) |
56 | + } |
57 | + Component { |
58 | + id: iconPop |
59 | + Popover { |
60 | + id: iconPopover |
61 | + property string icon: "N/A" |
62 | + |
63 | + Column { |
64 | + anchors.top: parent.top |
65 | + anchors.left: parent.left |
66 | + anchors.right: parent.right |
67 | + |
68 | + ListItem.Standard { |
69 | + iconName: iconPopover.icon |
70 | + text: iconPopover.icon |
71 | + } |
72 | + } |
73 | + } |
74 | + } |
75 | + } |
76 | + } |
77 | + } |
78 | + } |
79 | } |
80 | } |
64 + property string icon: "N/A"
74 + property string icon: "N/A"
Why do we have this?