Merge lp:~kalikiana/u1db-qt/trunk into lp:u1db-qt

Proposed by Cris Dywan
Status: Rejected
Rejected by: Cris Dywan
Proposed branch: lp:~kalikiana/u1db-qt/trunk
Merge into: lp:u1db-qt
Diff against target: 127 lines (+39/-15)
6 files modified
CMakeLists.txt (+19/-5)
debian/changelog (+5/-0)
debian/control (+12/-6)
debian/libu1db-qt5-doc.install (+1/-0)
debian/rules (+1/-3)
documentation/u1db.qdocconf (+1/-1)
To merge this branch: bzr merge lp:~kalikiana/u1db-qt/trunk
Reviewer Review Type Date Requested Status
Cris Dywan Disapprove
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing
Review via email: mp+157664@code.launchpad.net

This proposal supersedes a proposal from 2013-04-05.

Commit message

Add -doc package containing offline documentation

Description of the change

Add -doc package containing offline documentation

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
lp:~kalikiana/u1db-qt/trunk updated
78. By Cris Dywan

Merge lp:u1db-qt

79. By Cris Dywan

Build and install docs like other files if BUILD_DOCS is defined

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
lp:~kalikiana/u1db-qt/trunk updated
80. By Cris Dywan

Add mkdir -p to ensure subfolders in output directory

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :
review: Disapprove

Unmerged revisions

80. By Cris Dywan

Add mkdir -p to ensure subfolders in output directory

79. By Cris Dywan

Build and install docs like other files if BUILD_DOCS is defined

78. By Cris Dywan

Merge lp:u1db-qt

77. By Cris Dywan

Go back to bare make doc, dh_auto_build silently ignores it

76. By Cris Dywan

Enforce building docs relative to toplevel source folder

75. By Cris Dywan

Use variable to binary-relative docs dir

74. By Cris Dywan

Fix build dependencies and section/ architecture of -doc package

73. By Cris Dywan

Use dh_auto_build instead of bare make

72. By Cris Dywan

Don't set /opt/qt5 (LD_LIBRARY_)PATH in debian/rules

71. By Cris Dywan

Add -doc package containing offline documentation

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'CMakeLists.txt'
2--- CMakeLists.txt 2013-04-10 14:56:02 +0000
3+++ CMakeLists.txt 2013-04-11 12:45:43 +0000
4@@ -77,11 +77,19 @@
5 enable_testing()
6
7 add_custom_target(check COMMAND "env" "CTEST_OUTPUT_ON_FAILURE=1" "${CMAKE_CTEST_COMMAND}")
8-add_custom_target(doc "qdoc" "u1db.qdocconf"
9- COMMAND "sed" "-r" "-i" "'s@(</head>)@<link rel=\"stylesheet\" type=\"text/css\" href=\"style/base.css\" />\\1@'" "./output/html/*.html"
10- COMMAND "qhelpgenerator" "./output/html/u1dbqt.qhp"
11- COMMAND "assistant" "-register" "./output/html/u1dbqt.qch"
12- WORKING_DIRECTORY "documentation")
13+
14+option(BUILD_DOCS "Build documentation" OFF)
15+if (BUILD_DOCS)
16+ set(ALL "ALL")
17+endif ()
18+set(U1DB_DOCS "${PROJECT_BINARY_DIR}/documentation/output")
19+add_custom_target(doc ${ALL} "mkdir" "-p" "${U1DB_DOCS}"
20+ COMMAND "qdoc" "-outputdir" "${U1DB_DOCS}" "${CMAKE_SOURCE_DIR}/documentation/u1db.qdocconf" "1>/dev/null" "2>/dev/null"
21+ COMMAND "sed" "-r" "-i" "'s@(</head>)@<link rel=\"stylesheet\" type=\"text/css\" href=\"style/base.css\" />\\1@'" "${U1DB_DOCS}/*.html"
22+ COMMAND "qhelpgenerator" "${U1DB_DOCS}/u1dbqt.qhp"
23+ COMMAND "assistant" "-register" "${U1DB_DOCS}/u1dbqt.qch"
24+ SOURCES "${CMAKE_SOURCE_DIR}/documentation/u1db.qdocconf"
25+ WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}/documentation")
26 add_subdirectory(modules)
27 add_subdirectory(tests)
28
29@@ -96,6 +104,12 @@
30 DESTINATION ${INCLUDE_INSTALL_DIR}
31 )
32
33+if (BUILD_DOCS)
34+ install(FILES "${U1DB_DOCS}/u1dbqt.qch"
35+ DESTINATION "${CMAKE_INSTALL_PREFIX}/share/qt5/phrasebooks/"
36+ )
37+endif ()
38+
39 # PkgConfig file
40 set (PREFIX "${CMAKE_INSTALL_PREFIX}")
41 set (EXEC_PREFIX "${CMAKE_INSTALL_PREFIX}")
42
43=== modified file 'debian/changelog'
44--- debian/changelog 2013-03-27 11:39:41 +0000
45+++ debian/changelog 2013-04-11 12:45:43 +0000
46@@ -1,3 +1,8 @@
47+u1db-qt (0.1.2) quantal; urgency=low
48+ * Add -doc package containing offline documentation
49+
50+ -- Christian Dywan <christian.dywan@canonical.com> Fri, 05 Apr 2013 12:52:13 +0200
51+
52 u1db-qt (0.1.1-0ubuntu1) quantal; urgency=low
53 * Added .install files
54 * Corrected dependencies
55
56=== modified file 'debian/control'
57--- debian/control 2013-04-09 12:41:08 +0000
58+++ debian/control 2013-04-11 12:45:43 +0000
59@@ -7,11 +7,7 @@
60 qtdeclarative5-dev,
61 qtbase5-dev,
62 dbus-test-runner,
63- qt5-default,
64- qtdeclarative5-test-plugin,
65- qtdeclarative5-qtquick2-plugin,
66- libqt5sql5-sqlite,
67- qtdeclarative5-dev-tools
68+ qttools5-dev-tools
69 Standards-Version: 3.9.3
70 Vcs-Bzr: https://launchpad.net/u1db-qt/trunk
71
72@@ -19,11 +15,21 @@
73 Architecture: any
74 Depends: ${shlibs:Depends},
75 ${misc:Depends},
76- qtdeclarative5-qtquick2-plugin,
77 libqt5sql5-sqlite
78 Description: Qt5 binding and QtQuick2 plugin for U1DB - shared library
79 Simple Qt5 binding and QtQuick2 plugin for U1DB (https://launchpad.net/u1db).
80
81+Package: libu1db-qt5-doc
82+Section: doc
83+Architecture: all
84+Depends: ${misc:Depends},
85+ libu1db-qt5-1 (= ${binary:Version}),
86+ qttools5-dev-tools
87+Description: Qt5 binding and QtQuick2 plugin for U1DB - offline documentation
88+ Simple Qt5 binding and QtQuick2 plugin for U1DB (https://launchpad.net/u1db).
89+ .
90+ This package contains the offline documentation for the Qt binding for U1DB
91+
92 Package: libu1db-qt5-dev
93 Section: libdevel
94 Architecture: any
95
96=== added file 'debian/libu1db-qt5-doc.install'
97--- debian/libu1db-qt5-doc.install 1970-01-01 00:00:00 +0000
98+++ debian/libu1db-qt5-doc.install 2013-04-11 12:45:43 +0000
99@@ -0,0 +1,1 @@
100+usr/share/qt5/phrasebooks/*
101
102=== modified file 'debian/rules'
103--- debian/rules 2013-04-09 11:32:11 +0000
104+++ debian/rules 2013-04-11 12:45:43 +0000
105@@ -10,9 +10,7 @@
106 dh $@ --parallel
107
108 override_dh_auto_configure:
109- PATH=/opt/qt5/bin:$(PATH) \
110- dh_auto_configure -- -DCMAKE_MODULE_PATH=/opt/qt5/lib/cmake \
111- -DLD_LIBRARY_PATH=/opt/qt5/lib:$(LD_LIBRARY_PATH)
112+ dh_auto_configure -- -DCMAKE_MODULE_PATH=/opt/qt5/lib/cmake -DBUILD_DOCS=ON
113
114 override_dh_auto_build:
115 dh_auto_build
116
117=== modified file 'documentation/u1db.qdocconf'
118--- documentation/u1db.qdocconf 2013-04-08 10:32:14 +0000
119+++ documentation/u1db.qdocconf 2013-04-11 12:45:43 +0000
120@@ -30,7 +30,7 @@
121 examples.fileextensions = "*.cpp *.h *.js *.xq *.svg *.xml *.ui *.qhp *.qhcp"
122 examples.imageextensions = "*.png *.jpeg *.jpg *.gif *.mng"
123
124-outputdir = output/html
125+outputdir = output
126 outputformats = HTML
127 syntaxhighlighting = true
128

Subscribers

People subscribed via source and target branches

to all changes: