Merge lp:~kalikiana/u1db-qt/pkglicense into lp:u1db-qt

Proposed by Cris Dywan
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 104
Merged at revision: 94
Proposed branch: lp:~kalikiana/u1db-qt/pkglicense
Merge into: lp:u1db-qt
Diff against target: 216 lines (+137/-1)
9 files modified
debian/control (+1/-0)
documentation/style/css.css (+16/-0)
documentation/style/css_002.css (+16/-0)
documentation/style/qtquick.css (+16/-0)
documentation/style/scratch.css (+16/-0)
tests/CMakeLists.txt (+3/-1)
tests/checklicense.sh (+33/-0)
tests/qt-backend-wrapper.cpp (+19/-0)
tests/strict-qmltestrunner.sh (+17/-0)
To merge this branch: bzr merge lp:~kalikiana/u1db-qt/pkglicense
Reviewer Review Type Date Requested Status
Timo Jyrinki Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+177381@code.launchpad.net

Commit message

Resolve missing copyright and license details

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Looks good, builds / runs tests fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-07-29 10:12:58 +0000
3+++ debian/control 2013-07-29 15:07:26 +0000
4@@ -3,6 +3,7 @@
5 Priority: optional
6 Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
7 Build-Depends: debhelper (>= 9),
8+ devscripts,
9 cmake (>= 2.8.6),
10 qtdeclarative5-dev,
11 qtbase5-dev,
12
13=== modified file 'documentation/style/css.css'
14--- documentation/style/css.css 2013-04-08 10:32:14 +0000
15+++ documentation/style/css.css 2013-07-29 15:07:26 +0000
16@@ -1,3 +1,19 @@
17+/*
18+ * Copyright (C) 2013 Canonical, Ltd.
19+ *
20+ * This program is free software; you can redistribute it and/or modify
21+ * it under the terms of the GNU Lesser General Public License as published by
22+ * the Free Software Foundation; version 3.
23+ *
24+ * This program is distributed in the hope that it will be useful,
25+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
26+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
27+ * GNU Lesser General Public License for more details.
28+ *
29+ * You should have received a copy of the GNU Lesser General Public License
30+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
31+ */
32+
33 @font-face {
34 font-family: 'Ubuntu';
35 font-style: normal;
36
37=== modified file 'documentation/style/css_002.css'
38--- documentation/style/css_002.css 2013-04-08 10:32:14 +0000
39+++ documentation/style/css_002.css 2013-07-29 15:07:26 +0000
40@@ -1,3 +1,19 @@
41+/*
42+ * Copyright (C) 2013 Canonical, Ltd.
43+ *
44+ * This program is free software; you can redistribute it and/or modify
45+ * it under the terms of the GNU Lesser General Public License as published by
46+ * the Free Software Foundation; version 3.
47+ *
48+ * This program is distributed in the hope that it will be useful,
49+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
50+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
51+ * GNU Lesser General Public License for more details.
52+ *
53+ * You should have received a copy of the GNU Lesser General Public License
54+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
55+ */
56+
57 @font-face {
58 font-family: 'Ubuntu Mono';
59 font-style: normal;
60
61=== modified file 'documentation/style/qtquick.css'
62--- documentation/style/qtquick.css 2013-04-08 10:32:14 +0000
63+++ documentation/style/qtquick.css 2013-07-29 15:07:26 +0000
64@@ -1,3 +1,19 @@
65+/*
66+ * Copyright (C) 2013 Canonical, Ltd.
67+ *
68+ * This program is free software; you can redistribute it and/or modify
69+ * it under the terms of the GNU Lesser General Public License as published by
70+ * the Free Software Foundation; version 3.
71+ *
72+ * This program is distributed in the hope that it will be useful,
73+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
74+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
75+ * GNU Lesser General Public License for more details.
76+ *
77+ * You should have received a copy of the GNU Lesser General Public License
78+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
79+ */
80+
81 @media screen
82 {
83
84
85=== modified file 'documentation/style/scratch.css'
86--- documentation/style/scratch.css 2013-04-08 10:32:14 +0000
87+++ documentation/style/scratch.css 2013-07-29 15:07:26 +0000
88@@ -1,3 +1,19 @@
89+/*
90+ * Copyright (C) 2013 Canonical, Ltd.
91+ *
92+ * This program is free software; you can redistribute it and/or modify
93+ * it under the terms of the GNU Lesser General Public License as published by
94+ * the Free Software Foundation; version 3.
95+ *
96+ * This program is distributed in the hope that it will be useful,
97+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
98+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
99+ * GNU Lesser General Public License for more details.
100+ *
101+ * You should have received a copy of the GNU Lesser General Public License
102+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
103+ */
104+
105 body {
106 margin: 0;
107 }
108
109=== modified file 'tests/CMakeLists.txt'
110--- tests/CMakeLists.txt 2013-04-30 00:23:18 +0000
111+++ tests/CMakeLists.txt 2013-07-29 15:07:26 +0000
112@@ -2,7 +2,7 @@
113
114 find_package(Qt5Test REQUIRED)
115
116-add_test(NAME plugintest COMMAND "${CMAKE_CURRENT_SOURCE_DIR}/strict-qmltestrunner" "-platform" "minimal" "-import" "../modules" "-xunitxml" "-o" "plugintest-xunit.xml" "-input" "${CMAKE_CURRENT_SOURCE_DIR}")
117+add_test(NAME plugintest COMMAND "${CMAKE_CURRENT_SOURCE_DIR}/strict-qmltestrunner.sh" "-platform" "minimal" "-import" "../modules" "-xunitxml" "-o" "plugintest-xunit.xml" "-input" "${CMAKE_CURRENT_SOURCE_DIR}")
118
119 include_directories(
120 ${CMAKE_CURRENT_BINARY_DIR}
121@@ -46,3 +46,5 @@
122 endif ()
123 endif ()
124
125+add_test(NAME licensetest COMMAND "${CMAKE_CURRENT_SOURCE_DIR}/checklicense.sh" WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}")
126+
127
128=== added file 'tests/checklicense.sh'
129--- tests/checklicense.sh 1970-01-01 00:00:00 +0000
130+++ tests/checklicense.sh 2013-07-29 15:07:26 +0000
131@@ -0,0 +1,33 @@
132+#!/usr/bin/env sh
133+#
134+# Copyright 2013 Canonical Ltd.
135+#
136+# This program is free software; you can redistribute it and/or modify
137+# it under the terms of the GNU Lesser General Public License as published by
138+# the Free Software Foundation; version 3.
139+#
140+# This program is distributed in the hope that it will be useful,
141+# but WITHOUT ANY WARRANTY; without even the implied warranty of
142+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
143+# GNU Lesser General Public License for more details.
144+#
145+# You should have received a copy of the GNU Lesser General Public License
146+# along with this program. If not, see <http://www.gnu.org/licenses/>.
147+#
148+################################################################################
149+PATTERN='\.(c(c|pp|xx)?|h(h|pp|xx)?|p(l|m)|php|py(|x)|java|js|css|vala|qml|sh)$'
150+SKIP='(_build|CMakeFiles|Canonical|GENERATED FILE|Yahoo! Inc. All rights reserved)'
151+COMMAND="licensecheck --noconf -r * --copyright -c $PATTERN"
152+echo Executing $COMMAND
153+RESULTS=$($COMMAND)
154+test $? = 0 || exit 1
155+ERRORS=$(echo "$RESULTS" | egrep -v "$SKIP" | grep '*No copyright*')
156+COUNT=$(echo "$ERRORS" | sed 's/^ *//g' | wc -l)
157+if [ "$ERRORS" = "" ]; then
158+ echo No license problems found.
159+ exit 0
160+else
161+ echo Found $COUNT license problems:
162+ echo "$ERRORS"
163+ exit 1
164+fi
165
166=== modified file 'tests/qt-backend-wrapper.cpp'
167--- tests/qt-backend-wrapper.cpp 2013-03-27 16:51:12 +0000
168+++ tests/qt-backend-wrapper.cpp 2013-07-29 15:07:26 +0000
169@@ -1,3 +1,22 @@
170+/*
171+ * Copyright (C) 2013 Canonical, Ltd.
172+ *
173+ * Authors:
174+ * Christian Dywan <christian.dywan@canonical.com>
175+ *
176+ * This program is free software; you can redistribute it and/or modify
177+ * it under the terms of the GNU Lesser General Public License as published by
178+ * the Free Software Foundation; version 3.
179+ *
180+ * This program is distributed in the hope that it will be useful,
181+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
182+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
183+ * GNU Lesser General Public License for more details.
184+ *
185+ * You should have received a copy of the GNU Lesser General Public License
186+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
187+ */
188+
189 #include <Python.h>
190 #include "database.h"
191 #include <QDebug>
192
193=== renamed file 'tests/strict-qmltestrunner' => 'tests/strict-qmltestrunner.sh'
194--- tests/strict-qmltestrunner 2013-04-30 00:23:18 +0000
195+++ tests/strict-qmltestrunner.sh 2013-07-29 15:07:26 +0000
196@@ -1,3 +1,20 @@
197 #!/usr/bin/env sh
198+#!/usr/bin/env sh
199+#
200+# Copyright 2013 Canonical Ltd.
201+#
202+# This program is free software; you can redistribute it and/or modify
203+# it under the terms of the GNU Lesser General Public License as published by
204+# the Free Software Foundation; version 3.
205+#
206+# This program is distributed in the hope that it will be useful,
207+# but WITHOUT ANY WARRANTY; without even the implied warranty of
208+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
209+# GNU Lesser General Public License for more details.
210+#
211+# You should have received a copy of the GNU Lesser General Public License
212+# along with this program. If not, see <http://www.gnu.org/licenses/>.
213+#
214+################################################################################
215 qmltestrunner $* || exit 1
216 test 0 -eq $(grep -c qwarn plugintest-xunit.xml) || exit 1

Subscribers

People subscribed via source and target branches

to all changes: