Merge lp:~kalikiana/midori/largerdialog into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: André Stösel
Approved revision: 6246
Merged at revision: 6304
Proposed branch: lp:~kalikiana/midori/largerdialog
Merge into: lp:midori
Diff against target: 38 lines (+7/-3)
2 files modified
data/about.css (+2/-2)
midori/midori-view.c (+5/-1)
To merge this branch: bzr merge lp:~kalikiana/midori/largerdialog
Reviewer Review Type Date Requested Status
André Stösel Approve
Review via email: mp+173346@code.launchpad.net

Commit message

Define large dialog icon size relative to dialog icon size

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Would this be seen as a bug fix? Though I guess it's not super critical so we might also wait for after release.

Revision history for this message
André Stösel (ivaldi) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/about.css'
2--- data/about.css 2013-06-29 22:38:04 +0000
3+++ data/about.css 2013-07-07 08:02:26 +0000
4@@ -19,7 +19,7 @@
5 }
6
7 .indent {
8- margin-left: 60px;
9+ margin-left: 5%;
10 }
11
12 #main {
13@@ -38,7 +38,7 @@
14 }
15
16 #text {
17- margin-left: 80px;
18+ margin-left: 15%;
19 }
20
21 h1 {
22
23=== modified file 'midori/midori-view.c'
24--- midori/midori-view.c 2013-07-01 20:20:33 +0000
25+++ midori/midori-view.c 2013-07-07 08:02:26 +0000
26@@ -886,7 +886,11 @@
27 static gint icon_size_large_dialog = 0;
28
29 if (!icon_size_large_dialog)
30- icon_size_large_dialog = gtk_icon_size_register ("large-dialog", 64, 64);
31+ {
32+ gint width = 48, height = 48;
33+ gtk_icon_size_lookup (GTK_ICON_SIZE_DIALOG, &width, &height);
34+ icon_size_large_dialog = gtk_icon_size_register ("large-dialog", width * 2, height * 2);
35+ }
36
37 if (g_ascii_isalpha (icon_name[0]))
38 {

Subscribers

People subscribed via source and target branches

to all changes: