Merge lp:~kalikiana/midori/growl into lp:midori

Proposed by Cris Dywan
Status: Rejected
Rejected by: Cris Dywan
Proposed branch: lp:~kalikiana/midori/growl
Merge into: lp:midori
Diff against target: 15 lines (+6/-0)
1 file modified
midori/midori-app.c (+6/-0)
To merge this branch: bzr merge lp:~kalikiana/midori/growl
Reviewer Review Type Date Requested Status
Cris Dywan Disapprove
André Stösel Needs Fixing
Review via email: mp+167167@code.launchpad.net

Description of the change

Fallback to infobar in current tab instead of notification

To post a comment you must log in.
Revision history for this message
André Stösel (ivaldi) wrote :

There is currently no way to close the notification.

review: Needs Fixing
Revision history for this message
Cris Dywan (kalikiana) wrote :

I think there's sort of a silent agreement that this isn't a convincing alternative for notifications. It may just be better to actually have a simple popup window implemented by Midori.

review: Disapprove

Unmerged revisions

6192. By Cris Dywan

Fallback to infobar in current tab instead of notification

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-app.c'
2--- midori/midori-app.c 2013-05-30 11:08:14 +0000
3+++ midori/midori-app.c 2013-06-03 22:08:24 +0000
4@@ -1304,6 +1304,12 @@
5 notify_notification_show (note, NULL);
6 g_object_unref (note);
7 }
8+ #else
9+ g_return_if_fail (app->browser != NULL);
10+ GtkWidget* view = midori_browser_get_current_tab (app->browser);
11+ gchar* formatted = g_strconcat (title, " ", message, NULL);
12+ midori_view_add_info_bar (MIDORI_VIEW (view), GTK_MESSAGE_INFO, formatted, NULL, NULL, NULL);
13+ g_free (formatted);
14 #endif
15 }
16

Subscribers

People subscribed via source and target branches

to all changes: