Midori Web Browser

Merge lp:~kalikiana/midori/formhistcrash into lp:midori

  1. formhistcrash
  2. Merge into trunk
Proposed by Cris Dywan
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6404
Merged at revision: 6407
Proposed branch: lp:~kalikiana/midori/formhistcrash
Merge into: lp:midori
Diff against target: 11 lines (+1/-0)
1 file modified
extensions/formhistory/formhistory-gdom-frontend.c (+1/-0)
To merge this branch: bzr merge lp:~kalikiana/midori/formhistcrash
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+186174@code.launchpad.net

Commit message

Initialize priv->element to avoid crash when freeing

Description of the change

The crash can occur when disabling form history in the preferences.

To post a comment you must log in.
Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/formhistory/formhistory-gdom-frontend.c'
2--- extensions/formhistory/formhistory-gdom-frontend.c 2013-06-17 19:15:01 +0000
3+++ extensions/formhistory/formhistory-gdom-frontend.c 2013-09-17 22:15:04 +0000
4@@ -503,6 +503,7 @@
5 column = gtk_tree_view_column_new_with_attributes ("suggestions", renderer, "text", 0, NULL);
6 gtk_tree_view_append_column (GTK_TREE_VIEW (treeview), column);
7 priv->popup = popup;
8+ priv->element = NULL;
9
10 g_signal_connect (treeview, "button-press-event",
11 G_CALLBACK (formhistory_suggestion_selected_cb), priv);

Subscribers

People subscribed via source and target branches

to all changes: