Merge lp:~kalikiana/midori/foldermess into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6319
Merged at revision: 6320
Proposed branch: lp:~kalikiana/midori/foldermess
Merge into: lp:midori
Diff against target: 79 lines (+24/-21)
2 files modified
data/com.nokia.midori.service (+0/-3)
wscript (+24/-18)
To merge this branch: bzr merge lp:~kalikiana/midori/foldermess
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+178481@code.launchpad.net

Commit message

 Split config files and install from folders recursively

Description of the change

Install behavior essentially unchanged - except new files are picked up from 'config' and 'data' in the source without a change to the build.
.desktop files, faq.* and midori.* remain special-cased to avoid unnecessary bugs
This fixes nojs file installation.
(It should take care of tabby as well, though wrt the freeze that's not a concern)
I dropped data/com.nokia.midori.service - it's been unused for a while, and we can avoid a special-case for it

To post a comment you must log in.
Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'config'
2=== renamed directory 'data/extensions' => 'config/extensions'
3=== renamed file 'data/search' => 'config/search'
4=== removed file 'data/com.nokia.midori.service'
5--- data/com.nokia.midori.service 2009-01-27 01:57:40 +0000
6+++ data/com.nokia.midori.service 1970-01-01 00:00:00 +0000
7@@ -1,3 +0,0 @@
8-[D-BUS Service]
9-Name=com.nokia.midori
10-Exec=/usr/bin/midori
11
12=== modified file 'wscript'
13--- wscript 2013-07-30 21:00:46 +0000
14+++ wscript 2013-08-04 23:40:37 +0000
15@@ -466,9 +466,6 @@
16 bld.install_files ('${DOCDIR}/', \
17 'AUTHORS COPYING ChangeLog EXPAT README data/faq.html data/faq.css')
18
19- # Install default configuration
20- bld.install_files ('${SYSCONFDIR}/xdg/' + APPNAME + '/', 'data/search')
21-
22 if bld.env['INTLTOOL']:
23 obj = bld.new_task_gen ('intltool_po')
24 obj.podir = 'po'
25@@ -478,9 +475,12 @@
26 bld.add_subdirs ('docs/api')
27 bld.install_files ('${DOCDIR}/api/', blddir + '/docs/api/*')
28
29- for desktop in [APPNAME + '.desktop', APPNAME + '-private.desktop']:
30+ for res_file in os.listdir ('data'):
31 if is_win32 (bld.env):
32 break
33+ if not '.desktop' in res_file:
34+ continue
35+ desktop = res_file[:-3]
36 appdir = '${MDATADIR}/applications'
37 if bld.env['INTLTOOL']:
38 obj = bld.new_task_gen ('intltool_in')
39@@ -519,20 +519,26 @@
40 else:
41 Utils.pprint ('BLUE', "logo-shade could not be rasterized.")
42
43- for res_file in ['about.css', 'error.html', 'close.png', 'gtk3.css', 'speeddial-head.html']:
44- bld.install_files ('${MDATADIR}/' + APPNAME + '/res', 'data/' + res_file)
45-
46- if bld.env['addons']:
47- bld.install_files ('${MDATADIR}/' + APPNAME + '/res', 'data/autosuggestcontrol.js')
48- bld.install_files ('${MDATADIR}/' + APPNAME + '/res', 'data/autosuggestcontrol.css')
49-
50- if 1:
51- extensions = os.listdir ('data/extensions')
52- for extension in extensions:
53- source = 'data/extensions/' + extension + '/config'
54- if os.path.exists (source):
55- bld.install_files ('${SYSCONFDIR}/xdg/' + APPNAME + \
56- '/extensions/' + extension, source)
57+ for res_file in os.listdir ('data'):
58+ if '.desktop' in res_file or 'faq.' in res_file or 'midori.' in res_file:
59+ continue
60+ dest = '${MDATADIR}/' + APPNAME + '/res'
61+ if (os.path.isdir ('data/' + res_file)):
62+ dest += '/' + res_file
63+ res_file += '/*'
64+ bld.install_files (dest, 'data/' + res_file)
65+
66+ for config_file in os.listdir ('config'):
67+ dest = '${SYSCONFDIR}/xdg/' + APPNAME
68+ if (os.path.isdir ('config/' + config_file)):
69+ dest += '/' + config_file
70+ for child in os.listdir ('config/' + config_file):
71+ if (os.path.isdir ('config/' + config_file + '/' + child)):
72+ dest += '/' + child
73+ child += '/*'
74+ bld.install_files (dest, 'config/' + config_file + '/' + child)
75+ continue
76+ bld.install_files (dest, 'config/' + config_file)
77
78 if Options.commands['check'] or bld.env['tests']:
79 bld.add_subdirs ('tests')

Subscribers

People subscribed via source and target branches

to all changes: