Midori Web Browser

Merge lp:~kalikiana/midori/dnmenu into lp:midori

  1. dnmenu
  2. Merge into trunk
Proposed by Cris Dywan
Status: Merged
Approved by: André Stösel
Approved revision: 6198
Merged at revision: 6218
Proposed branch: lp:~kalikiana/midori/dnmenu
Merge into: lp:midori
Diff against target: 15 lines (+3/-0)
1 file modified
midori/midori-view.c (+3/-0)
To merge this branch: bzr merge lp:~kalikiana/midori/dnmenu
Reviewer Review Type Date Requested Status
André Stösel Approve
Review via email: mp+167862@code.launchpad.net

Commit message

Set menu on dynamic notebook tab

Description of the change

Set menu on dynamic notebook tab

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

You'll see that it works when "Show Icon Only" is included in the context menu of tab labels.

Revision history for this message
André Stösel (ivaldi) wrote :

Hm, now the tab menu is shown, but the actions behind some items (like "Show Icon Only") are buggy.
However, this is a proper patch.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'midori/midori-view.c'
2--- midori/midori-view.c 2013-05-31 09:22:08 +0000
3+++ midori/midori-view.c 2013-06-06 22:34:26 +0000
4@@ -716,8 +716,11 @@
5
6 #ifdef HAVE_GRANITE
7 if (view->tab)
8+ {
9 g_object_set (view->tab, "working",
10 midori_view_get_progress (view) > 0.0, NULL);
11+ g_object_set (view->tab, "menu", midori_view_get_tab_menu (view), NULL);
12+ }
13 #else
14 if (view->tab_icon)
15 katze_throbber_set_animated (KATZE_THROBBER (view->tab_icon),

Subscribers

People subscribed via source and target branches

to all changes: