Merge lp:~kalikiana/midori/devpetstock into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: André Stösel
Approved revision: 6404
Merged at revision: 6404
Proposed branch: lp:~kalikiana/midori/devpetstock
Merge into: lp:midori
Diff against target: 30 lines (+3/-3)
1 file modified
extensions/devpet.vala (+3/-3)
To merge this branch: bzr merge lp:~kalikiana/midori/devpetstock
Reviewer Review Type Date Requested Status
André Stösel Approve
Review via email: mp+186175@code.launchpad.net

Commit message

Use stock as string in liststore

Description of the change

I was seeing errors about gtk-dialog not being found - these are stock items and shouldn't be passed to API that expects icon names.

To post a comment you must log in.
Revision history for this message
André Stösel (ivaldi) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/devpet.vala'
2--- extensions/devpet.vala 2013-08-03 21:03:31 +0000
3+++ extensions/devpet.vala 2013-09-17 22:16:40 +0000
4@@ -118,7 +118,7 @@
5
6 treeview.insert_column_with_attributes (
7 -1, "Type",
8- new Gtk.CellRendererPixbuf (), "pixbuf", TreeCells.STOCK);
9+ new Gtk.CellRendererPixbuf (), "stock-id", TreeCells.STOCK);
10 treeview.insert_column_with_attributes (
11 -1, "Message",
12 new Gtk.CellRendererText (), "text", TreeCells.MESSAGE);
13@@ -194,7 +194,7 @@
14 #if !HAVE_WIN32
15 TreeCells.BACKTRACE, bt,
16 #endif
17- TreeCells.STOCK, theme.load_icon (stock, 16, 0));
18+ TreeCells.STOCK, stock);
19
20 this.trayicon.set_visible (true);
21 }
22@@ -233,7 +233,7 @@
23 this.trayicon.set_tooltip_text ("Midori - DevPet");
24 this.trayicon.activate.connect(this.show_error_log);
25
26- this.list_store = new Gtk.ListStore (TreeCells.COUNT, typeof(string), typeof(string), typeof (Gdk.Pixbuf));
27+ this.list_store = new Gtk.ListStore (TreeCells.COUNT, typeof(string), typeof(string), typeof (string));
28
29 this.activate.connect (this.activated);
30 this.deactivate.connect (this.deactivated);

Subscribers

People subscribed via source and target branches

to all changes: