Merge lp:~kalikiana/midori/defaultzoom into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: André Stösel
Approved revision: 6248
Merged at revision: 6248
Proposed branch: lp:~kalikiana/midori/defaultzoom
Merge into: lp:midori
Diff against target: 111 lines (+35/-1)
5 files modified
katze/katze-utils.c (+16/-0)
midori/midori-preferences.c (+6/-0)
midori/midori-settings.vala (+2/-0)
midori/midori-view.c (+3/-0)
midori/midori-websettings.c (+8/-1)
To merge this branch: bzr merge lp:~kalikiana/midori/defaultzoom
Reviewer Review Type Date Requested Status
André Stösel Approve
Review via email: mp+173351@code.launchpad.net

Commit message

Implement a default zoom level preference

To post a comment you must log in.
Revision history for this message
André Stösel (ivaldi) wrote :

What about [ctrl+0] (normal size)?
I'm not quite sure what to expect...

 - normal = 100%
 or
 - normal = default zoom

Revision history for this message
André Stösel (ivaldi) wrote :

We talked about this in IRC and came to the conclusion that [CTRL+0] should reset the zoom to 100%.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'katze/katze-utils.c'
2--- katze/katze-utils.c 2013-04-16 23:16:24 +0000
3+++ katze/katze-utils.c 2013-07-07 12:29:26 +0000
4@@ -705,6 +705,22 @@
5 G_CALLBACK (proxy_widget_string_destroy_cb), object);
6 g_free (notify_property);
7 }
8+ else if (type == G_TYPE_PARAM_DOUBLE)
9+ {
10+ gdouble value;
11+ g_object_get (object, property, &value, NULL);
12+
13+ widget = gtk_spin_button_new_with_range (
14+ G_PARAM_SPEC_DOUBLE (pspec)->minimum,
15+ G_PARAM_SPEC_DOUBLE (pspec)->maximum, 1);
16+ /* Keep it narrow, 5 + 2 digits are usually fine */
17+ gtk_entry_set_width_chars (GTK_ENTRY (widget), 5 + 2);
18+ gtk_spin_button_set_digits (GTK_SPIN_BUTTON (widget), 2);
19+ gtk_spin_button_set_value (GTK_SPIN_BUTTON (widget), value);
20+ gtk_spin_button_set_increments (GTK_SPIN_BUTTON (widget), 0.1, -0.1);
21+ g_signal_connect (widget, "value-changed",
22+ G_CALLBACK (proxy_spin_button_changed_cb), object);
23+ }
24 else if (type == G_TYPE_PARAM_FLOAT)
25 {
26 gfloat value;
27
28=== modified file 'midori/midori-preferences.c'
29--- midori/midori-preferences.c 2013-06-26 21:54:50 +0000
30+++ midori/midori-preferences.c 2013-07-07 12:29:26 +0000
31@@ -403,6 +403,12 @@
32 gtk_button_set_label (GTK_BUTTON (button), _("Allow scripts to open popups"));
33 gtk_widget_set_tooltip_text (button, _("Whether scripts are allowed to open popup windows automatically"));
34 SPANNED_ADD (button);
35+ label = gtk_label_new (_("Default Zoom Level"));
36+ gtk_misc_set_alignment (GTK_MISC (label), 0.0, 0.5);
37+ INDENTED_ADD (label);
38+ button = katze_property_proxy (settings, "zoom-level", NULL);
39+ gtk_widget_set_tooltip_text (button, _("Initial factor to enlarge newly opened tabs by"));
40+ SPANNED_ADD (button);
41
42 FRAME_NEW (NULL);
43 button = gtk_label_new (_("Preferred languages"));
44
45=== modified file 'midori/midori-settings.vala'
46--- midori/midori-settings.vala 2013-04-11 20:33:43 +0000
47+++ midori/midori-settings.vala 2013-07-07 12:29:26 +0000
48@@ -119,6 +119,8 @@
49 /* Since: 0.1.4 */
50 // [Deprecated (since = "0.4.7")]
51 public bool find_while_typing { get; set; default = false; }
52+ /* Since: 0.5.4 */
53+ public double zoom_level { get; set; default = 1.0; }
54
55 public bool open_popups_in_tabs { get; set; default = true; }
56 /* Since: 0.2.0 */
57
58=== modified file 'midori/midori-view.c'
59--- midori/midori-view.c 2013-07-01 20:20:33 +0000
60+++ midori/midori-view.c 2013-07-07 12:29:26 +0000
61@@ -3280,6 +3280,7 @@
62 MidoriWebSettings* settings)
63 {
64 gboolean zoom_text_and_images;
65+ gdouble zoom_level;
66
67 if (view->settings)
68 g_signal_handlers_disconnect_by_func (view->settings,
69@@ -3294,6 +3295,7 @@
70 G_CALLBACK (midori_view_settings_notify_cb), view);
71
72 g_object_get (view->settings,
73+ "zoom-level", &zoom_level,
74 "zoom-text-and-images", &zoom_text_and_images,
75 "close-buttons-on-tabs", &view->close_buttons_on_tabs,
76 "open-new-pages-in", &view->open_new_pages_in,
77@@ -3305,6 +3307,7 @@
78 webkit_web_view_set_full_content_zoom (WEBKIT_WEB_VIEW (view->web_view),
79 zoom_text_and_images);
80 #endif
81+ midori_view_set_zoom_level (view, zoom_level);
82 }
83
84 /**
85
86=== modified file 'midori/midori-websettings.c'
87--- midori/midori-websettings.c 2013-06-19 20:20:05 +0000
88+++ midori/midori-websettings.c 2013-07-07 12:29:26 +0000
89@@ -1395,7 +1395,7 @@
90 integer = g_key_file_get_integer (key_file, "settings", property, NULL);
91 g_object_set (settings, property, integer, NULL);
92 }
93- else if (type == G_TYPE_PARAM_FLOAT)
94+ else if (type == G_TYPE_PARAM_FLOAT || type == G_TYPE_PARAM_DOUBLE)
95 {
96 number = g_key_file_get_double (key_file, "settings", property, NULL);
97 g_object_set (settings, property, number, NULL);
98@@ -1504,6 +1504,13 @@
99 if (integer != G_PARAM_SPEC_UINT (pspec)->default_value)
100 g_key_file_set_integer (key_file, "settings", property, integer);
101 }
102+ else if (type == G_TYPE_PARAM_DOUBLE)
103+ {
104+ gdouble number;
105+ g_object_get (settings, property, &number, NULL);
106+ if (number != G_PARAM_SPEC_DOUBLE (pspec)->default_value)
107+ g_key_file_set_double (key_file, "settings", property, number);
108+ }
109 else if (type == G_TYPE_PARAM_FLOAT)
110 {
111 gfloat number;

Subscribers

People subscribed via source and target branches

to all changes: