Merge lp:~kalikiana/midori/bzr-release-scripts into lp:midori

Proposed by Cris Dywan
Status: Merged
Merged at revision: 6161
Proposed branch: lp:~kalikiana/midori/bzr-release-scripts
Merge into: lp:midori
Diff against target: 89 lines (+12/-11)
3 files modified
tools/midori-dev (+6/-6)
tools/release (+5/-4)
win32/makedist/win32-release (+1/-1)
To merge this branch: bzr merge lp:~kalikiana/midori/bzr-release-scripts
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+164624@code.launchpad.net

Description of the change

Port git-specific bits from release scripts to bzr

To post a comment you must log in.
Revision history for this message
Paweł Forysiuk (tuxator) wrote :

+ OLDVER=0.5.1 (line 51)
is that on purpose? it is because there is no git tag?

Revision history for this message
Paweł Forysiuk (tuxator) :
review: Approve
Revision history for this message
Cris Dywan (kalikiana) wrote :

I realized the wscript is what contains the version and avoids the race condition of running it twice, which happened to me before, and having to manually sort it out. This is why I didn't use equivalent bzr code.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tools/midori-dev'
2--- tools/midori-dev 2012-04-05 21:47:48 +0000
3+++ tools/midori-dev 2013-05-19 14:06:29 +0000
4@@ -9,10 +9,10 @@
5 #
6 # See the file COPYING for the full license text.
7 #
8-# midori-dev: Run, update or debug Midori from git.
9+# midori-dev: Run, update or debug Midori from bzr.
10
11-# Adjust this to where you have your git sources
12-DEVDIR=~/src/xfce/midori/git
13+# Adjust this to where you have your bzr sources
14+DEVDIR=~/src/xfce/midori/bzr
15
16 # Location of stdout and stderr from running midori
17 LOG=~/.midori.out
18@@ -40,7 +40,7 @@
19 fi
20
21 case $CMD in
22- git)
23+ bzr)
24 exec ./waf build --run "$@" >& $LOG
25 ;;
26 gdb)
27@@ -72,13 +72,13 @@
28 fi
29 ;;
30 pull)
31- git pull
32+ bzr pull
33 ;;
34 *)
35 cat << EOM
36 Usage: Create a symlink midori-<CMD>, or run 'midori-dev <CMD>'
37 where CMD can be
38- git: run the current git version
39+ bzr: run the current bzr version
40 gdb: open the last core dump in gdb
41 save: saves relevant information about the last crash
42 so that it can be analyzed later
43
44=== modified file 'tools/release'
45--- tools/release 2013-05-17 18:38:50 +0000
46+++ tools/release 2013-05-19 14:06:29 +0000
47@@ -9,24 +9,25 @@
48 #
49 # See the file COPYING for the full license text.
50
51-OLDVER=$(git describe --abbrev=0)
52+OLDVER=$(grep --color=no 'VERSION = VERSION_FULL = ' wscript | sed -r "s@.+ = '(.+)'@\1@")
53 NEWVER=$(python -c "print('0.'+str(float('$OLDVER'[2:])+.1))")
54 if [ "x$1" = "xbefore" ]; then
55 echo Bumping from $OLDVER to $NEWVER
56+ OLDVER=0.5.1
57 sed -i "s@$OLDVER@$NEWVER@g" wscript win32/makedist/midori.nsi
58- echo; echo v$NEWVER:; git log --pretty='format: %s' $OLDVER..HEAD | grep -v l10n | grep -v makedist | grep -v tools/release | grep -v nsi | grep -v -E 'Update .+ translation'; echo
59+ echo; echo v$NEWVER:; bzr log --line -rtag:$OLDVER.. | sed -r 's@.+2013-[0-9]+-[0-9]+ @@' | grep -v l10n | grep -v makedist | grep -v tools/release | grep -v nsi | grep -v -E 'Update .+ translation'; echo
60 curl http://wiki.xfce.org/_export/xhtml/midori/faq | \
61 sed 's@This is a list of frequently asked questions@This is <a href="http://wiki.xfce.org/midori/faq">a snapshot of the online FAQ</a>@g' | \
62 sed 's@<link rel="style.*>@<link rel="stylesheet" href="faq.css" />@g' > data/faq.html
63 elif [ "x$1" = "xafter" ]; then
64- echo -n git commit -m "'Bump version to $NEWVER'"
65+ echo -n bzr commit -p -m "'Bump version to $NEWVER'"
66 case $SHELL in
67 *fish*)
68 echo -n '; and ' ;;
69 *)
70 echo -n ' && ' ;;
71 esac
72- echo git tag -a $NEWVER -m "'Bump version to $NEWVER'"
73+ echo bzr tag $NEWVER
74 echo Press RETURN to download tarball now; read yes
75 wget http://git.xfce.org/apps/midori/snapshot/midori-$NEWVER.tar.bz2
76 echo https://releases.xfce.org/
77
78=== modified file 'win32/makedist/win32-release'
79--- win32/makedist/win32-release 2013-04-06 20:06:12 +0000
80+++ win32/makedist/win32-release 2013-05-19 14:06:29 +0000
81@@ -10,7 +10,7 @@
82 # See the file COPYING for the full license text.
83
84
85-version=$(git describe --abbrev=0)
86+version=$(grep --color=no 'VERSION = VERSION_FULL = ' wscript | sed -r "s@.+ = '(.+)'@\1@")
87 dropbox_dir=$HOME/Dropbox/Public
88
89 # 32-bit build

Subscribers

People subscribed via source and target branches

to all changes: