Merge lp:~kalikiana/midori/beetle into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6372
Merged at revision: 6373
Proposed branch: lp:~kalikiana/midori/beetle
Merge into: lp:midori
Diff against target: 164 lines (+4/-35)
4 files modified
extensions/adblock.c (+0/-9)
midori/midori-app.c (+4/-14)
midori/midori-session.c (+0/-8)
midori/midori-view.c (+0/-4)
To merge this branch: bzr merge lp:~kalikiana/midori/beetle
Reviewer Review Type Date Requested Status
Midori Devs Pending
Review via email: mp+183536@code.launchpad.net

Commit message

Drop all G_ENABLE_DEBUG guards

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/adblock.c'
2--- extensions/adblock.c 2013-08-12 19:21:06 +0000
3+++ extensions/adblock.c 2013-09-02 20:33:49 +0000
4@@ -28,12 +28,8 @@
5 __filter[4] = __active ? (__filter[5] == ':' ? 's' : ':') : '-'
6 #define ADBLOCK_FILTER_IS_SET(__filter) \
7 (__filter[4] != '-' && __filter[5] != '-')
8-#ifdef G_ENABLE_DEBUG
9 #define adblock_debug(dmsg, darg1, darg2) \
10 do { if (midori_debug ("adblock:match")) g_debug (dmsg, darg1, darg2); } while (0)
11-#else
12- #define adblock_debug(dmsg, darg1, darg2) /* nothing */
13-#endif
14
15 static GHashTable* pattern = NULL;
16 static GHashTable* keys = NULL;
17@@ -877,10 +873,8 @@
18 }
19 }
20
21- #ifdef G_ENABLE_DEBUG
22 if (midori_debug ("adblock:time"))
23 g_test_timer_start ();
24- #endif
25 if (adblock_is_matched (req_uri, page_uri))
26 {
27 blocked_uris = g_object_get_data (G_OBJECT (web_view), "blocked-uris");
28@@ -888,11 +882,8 @@
29 webkit_network_request_set_uri (request, "about:blank");
30 g_object_set_data (G_OBJECT (web_view), "blocked-uris", blocked_uris);
31 }
32- #ifdef G_ENABLE_DEBUG
33 if (midori_debug ("adblock:time"))
34 g_debug ("match: %f%s", g_test_timer_elapsed (), "seconds");
35- #endif
36-
37 }
38
39 static void
40
41=== modified file 'midori/midori-app.c'
42--- midori/midori-app.c 2013-09-01 12:49:06 +0000
43+++ midori/midori-app.c 2013-09-02 20:33:49 +0000
44@@ -1247,8 +1247,7 @@
45 midori_debug (const gchar* token)
46 {
47 static const gchar* debug_token = NULL;
48- const gchar* debug_tokens = "headers body referer cookies paths hsts unarmed bookmarks mouse app ";
49- const gchar* full_debug_tokens = "adblock:match adblock:time startup ";
50+ const gchar* debug_tokens = "adblock:match adblock:time startup headers body referer cookies paths hsts unarmed bookmarks mouse app ";
51 if (debug_token == NULL)
52 {
53 gchar* found_token;
54@@ -1258,15 +1257,7 @@
55 g_warning ("MIDORI_TOUCHSCREEN is obsolete: "
56 "GTK+ 3.4 enables touchscreens automatically, "
57 "older GTK+ versions aren't supported as of Midori 0.4.9");
58- if (debug && (found_token = strstr (full_debug_tokens, debug)) && *(found_token + strlen (debug)) == ' ')
59- {
60- #ifdef G_ENABLE_DEBUG
61- debug_token = g_intern_static_string (debug);
62- #else
63- g_warning ("Value '%s' for MIDORI_DEBUG requires a full debugging build.", debug);
64- #endif
65- }
66- else if (debug && (found_token = strstr (debug_tokens, debug)) && *(found_token + strlen (debug)) == ' ')
67+ if (debug && (found_token = strstr (debug_tokens, debug)) && *(found_token + strlen (debug)) == ' ')
68 debug_token = g_intern_static_string (debug);
69 else if (debug)
70 g_warning ("Unrecognized value '%s' for MIDORI_DEBUG.", debug);
71@@ -1275,12 +1266,11 @@
72 if (!debug_token)
73 {
74 debug_token = "INVALID";
75- g_print ("Supported values: %s\nWith full debugging: %s\n",
76- debug_tokens, full_debug_tokens);
77+ g_print ("Supported values: %s\n", debug_tokens);
78 }
79 }
80 if (debug_token != g_intern_static_string ("NONE")
81- && !strstr (debug_tokens, token) && !strstr (full_debug_tokens, token))
82+ && !strstr (debug_tokens, token))
83 g_warning ("Token '%s' passed to midori_debug is not a known token.", token);
84 return debug_token == g_intern_static_string (token);
85 }
86
87=== modified file 'midori/midori-session.c'
88--- midori/midori-session.c 2013-08-10 19:20:31 +0000
89+++ midori/midori-session.c 2013-09-02 20:33:49 +0000
90@@ -359,10 +359,8 @@
91 MidoriApp* app = MIDORI_APP (data);
92 gchar** keys = g_object_get_data (G_OBJECT (app), "extensions");
93 KatzeArray* extensions;
94- #ifdef G_ENABLE_DEBUG
95 gboolean startup_timer = midori_debug ("startup");
96 GTimer* timer = startup_timer ? g_timer_new () : NULL;
97- #endif
98
99 /* Load extensions */
100 extensions = katze_array_new (MIDORI_TYPE_EXTENSION);
101@@ -370,10 +368,8 @@
102 g_object_set (app, "extensions", extensions, NULL);
103 midori_extension_load_from_folder (app, keys, TRUE);
104
105- #ifdef G_ENABLE_DEBUG
106 if (startup_timer)
107 g_debug ("Extensions:\t%f", g_timer_elapsed (timer, NULL));
108- #endif
109
110 return FALSE;
111 }
112@@ -501,10 +497,8 @@
113 gchar** execute_commands = g_object_get_data (G_OBJECT (app), "execute-commands");
114 gchar* uri;
115 guint i = 0;
116- #ifdef G_ENABLE_DEBUG
117 gboolean startup_timer = midori_debug ("startup");
118 GTimer* timer = startup_timer ? g_timer_new () : NULL;
119- #endif
120
121 browser = midori_app_create_browser (app);
122 midori_session_persistent_settings (settings, app);
123@@ -588,10 +582,8 @@
124 if (execute_commands != NULL)
125 midori_app_send_command (app, execute_commands);
126
127- #ifdef G_ENABLE_DEBUG
128 if (startup_timer)
129 g_debug ("Session setup:\t%f", g_timer_elapsed (timer, NULL));
130- #endif
131
132 return FALSE;
133 }
134
135=== modified file 'midori/midori-view.c'
136--- midori/midori-view.c 2013-09-01 16:40:29 +0000
137+++ midori/midori-view.c 2013-09-02 20:33:49 +0000
138@@ -3859,12 +3859,10 @@
139 MidoriBrowser* browser = midori_browser_get_for_widget (GTK_WIDGET (view));
140 MidoriSpeedDial* dial = katze_object_get_object (browser, "speed-dial");
141 const gchar* html;
142- #ifdef G_ENABLE_DEBUG
143 GTimer* timer = NULL;
144
145 if (midori_debug ("startup"))
146 timer = g_timer_new ();
147- #endif
148
149 midori_tab_set_uri (MIDORI_TAB (view), uri);
150 midori_tab_set_mime_type (MIDORI_TAB (view), "text/html");
151@@ -3874,13 +3872,11 @@
152 html = dial != NULL ? midori_speed_dial_get_html (dial, NULL) : "";
153 midori_view_set_html (view, html, uri, NULL);
154
155- #ifdef G_ENABLE_DEBUG
156 if (midori_debug ("startup"))
157 {
158 g_debug ("Speed Dial: \t%fs", g_timer_elapsed (timer, NULL));
159 g_timer_destroy (timer);
160 }
161- #endif
162 }
163 else if (midori_uri_is_blank (uri))
164 {

Subscribers

People subscribed via source and target branches

to all changes: