Merge lp:~kalikiana/midori/appfileerrors into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: André Stösel
Approved revision: 6327
Merged at revision: 6327
Proposed branch: lp:~kalikiana/midori/appfileerrors
Merge into: lp:midori
Diff against target: 42 lines (+5/-5)
1 file modified
extensions/apps.vala (+5/-5)
To merge this branch: bzr merge lp:~kalikiana/midori/appfileerrors
Reviewer Review Type Date Requested Status
André Stösel Approve
Review via email: mp+179295@code.launchpad.net

Commit message

Enrich app error messages with filenames

To post a comment you must log in.
Revision history for this message
André Stösel (ivaldi) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/apps.vala'
2--- extensions/apps.vala 2013-08-06 20:20:49 +0000
3+++ extensions/apps.vala 2013-08-08 22:24:52 +0000
4@@ -85,9 +85,9 @@
5 _("You can now run <b>%s</b> from your launcher or menu").printf (name));
6 }
7 catch (Error error) {
8- warning (_("Failed to create new launcher: %s").printf (error.message));
9+ warning (_("Failed to create new launcher (%s): %s"), file.get_path (), error.message);
10 browser.send_notification (_("Error creating launcher"),
11- _("Failed to create new launcher: %s").printf (error.message));
12+ _("Failed to create new launcher (%s): %s").printf (file.get_path (), error.message));
13 }
14 }
15
16@@ -204,7 +204,7 @@
17 #endif
18 }
19 catch (Error error) {
20- GLib.critical (error.message);
21+ GLib.critical ("Failed to remove launcher (%s): %s", launcher.file.get_path (), error.message);
22 }
23 return true;
24 }
25@@ -338,7 +338,7 @@
26 }
27 }
28 catch (Error error) {
29- warning ("Application changed: %s", error.message);
30+ warning ("Application changed (%s): %s", file.get_path (), error.message);
31 }
32 }
33
34@@ -369,7 +369,7 @@
35 array.add_item (launcher);
36 }
37 catch (Error error) {
38- warning ("Failed to parse launcher: %s", error.message);
39+ warning ("Failed to parse launcher (%s): %s", file.get_path (), error.message);
40 }
41 }
42 }

Subscribers

People subscribed via source and target branches

to all changes: