Merge lp:~kalikiana/midori/alwaystransfers into lp:midori

Proposed by Cris Dywan
Status: Merged
Approved by: Paweł Forysiuk
Approved revision: 6192
Merged at revision: 6192
Proposed branch: lp:~kalikiana/midori/alwaystransfers
Merge into: lp:midori
Diff against target: 28 lines (+5/-3)
2 files modified
extensions/wscript_build (+4/-0)
wscript (+1/-3)
To merge this branch: bzr merge lp:~kalikiana/midori/alwaystransfers
Reviewer Review Type Date Requested Status
Paweł Forysiuk Approve
Review via email: mp+167130@code.launchpad.net

Commit message

Always build transfers extension even if addons are disabled

Description of the change

Always build transfers extension even if addons are disabled

To post a comment you must log in.
Revision history for this message
Paweł Forysiuk (tuxator) wrote :

Fixes the build with addons disabled. I guess it will do for now, but we really think about some long-term solution.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/wscript_build'
2--- extensions/wscript_build 2013-05-14 17:52:15 +0000
3+++ extensions/wscript_build 2013-06-03 19:45:44 +0000
4@@ -7,6 +7,10 @@
5
6 extensions = os.listdir ('extensions')
7 for extension in extensions:
8+ # FIXME In the absense of a proper mechanism, transfers is a stock extension
9+ if not bld.env['addons'] and extension != 'transfers.vala':
10+ continue
11+
12 folder = 'extensions' + os.sep + extension
13 if os.path.isdir (folder):
14 files = os.listdir (folder)
15
16=== modified file 'wscript'
17--- wscript 2013-06-01 19:58:42 +0000
18+++ wscript 2013-06-03 19:45:44 +0000
19@@ -480,9 +480,7 @@
20 bld.add_group ()
21
22 bld.add_subdirs ('midori icons')
23-
24- if bld.env['addons']:
25- bld.add_subdirs ('extensions')
26+ bld.add_subdirs ('extensions')
27
28 bld.add_group ()
29

Subscribers

People subscribed via source and target branches

to all changes: