Code review comment for lp:~kalgasnik/lightdm-gtk-greeter/post-2.0.0

Revision history for this message
Sean Davis (bluesabre) wrote :

Simon,

Actually, other than the configuration location (not really a "feature"), I'd say these are all bug fixes.

#1 is a critical bug that can leave the greeter completely non-functional.
#2 and #3 break accessibility by making the on-screen keyboard unusable.
#4 means that keyboard input would be lost without using a mouse.

I haven't tested the branch yet, but these all sound reasonable to me. I'll test it out this weekend.

« Back to merge proposal