Merge lp:~kalgasnik/lightdm-gtk-greeter/default_avatar_option into lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk

Proposed by Andrew P.
Status: Merged
Merged at revision: 158
Proposed branch: lp:~kalgasnik/lightdm-gtk-greeter/default_avatar_option
Merge into: lp:~lightdm-gtk-greeter-team/lightdm-gtk-greeter/trunk
Diff against target: 63 lines (+26/-2)
2 files modified
data/lightdm-gtk-greeter.conf (+1/-0)
src/lightdm-gtk-greeter.c (+25/-2)
To merge this branch: bzr merge lp:~kalgasnik/lightdm-gtk-greeter/default_avatar_option
Reviewer Review Type Date Requested Status
LightDM Gtk+ Greeter Development Team Pending
Review via email: mp+200067@code.launchpad.net

Description of the change

New option:
default-user-image = Image used as default user icon, path or #icon-name

To post a comment you must log in.
Revision history for this message
Sean Davis (bluesabre) wrote :

Looks good, merged in to trunk.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/lightdm-gtk-greeter.conf'
2--- data/lightdm-gtk-greeter.conf 2013-11-24 20:54:22 +0000
3+++ data/lightdm-gtk-greeter.conf 2013-12-26 12:37:42 +0000
4@@ -13,6 +13,7 @@
5 # clock-format = strftime-format string, e.g. %H:%M
6 # keyboard = command to launch on-screen keyboard
7 # position = main window position: x y
8+# default-user-image = Image used as default user icon, path or #icon-name
9 #
10 [greeter]
11 #background=
12
13=== modified file 'src/lightdm-gtk-greeter.c'
14--- src/lightdm-gtk-greeter.c 2013-12-13 02:56:06 +0000
15+++ src/lightdm-gtk-greeter.c 2013-12-26 12:37:42 +0000
16@@ -105,6 +105,9 @@
17 const WindowPosition CENTERED_WINDOW_POS = { .x = {50, +1, TRUE, 0}, .y = {50, +1, TRUE, 0} };
18 WindowPosition main_window_pos;
19
20+GdkPixbuf* default_user_pixbuf = NULL;
21+gchar* default_user_icon = "avatar-default";
22+
23
24 #ifdef HAVE_LIBINDICATOR
25 static gboolean
26@@ -500,8 +503,11 @@
27 }
28 }
29 }
30-
31- gtk_image_set_from_icon_name (GTK_IMAGE (user_image), "avatar-default", GTK_ICON_SIZE_DIALOG);
32+
33+ if (default_user_pixbuf)
34+ gtk_image_set_from_pixbuf (GTK_IMAGE (user_image), default_user_pixbuf);
35+ else
36+ gtk_image_set_from_icon_name (GTK_IMAGE (user_image), default_user_icon, GTK_ICON_SIZE_DIALOG);
37 }
38
39 #if GTK_CHECK_VERSION (3, 0, 0)
40@@ -2016,6 +2022,23 @@
41 }
42 #endif
43
44+ value = g_key_file_get_value (config, "greeter", "default-user-image", NULL);
45+ if (value)
46+ {
47+ if (value[0] == '#')
48+ default_user_icon = g_strdup (value + 1);
49+ else
50+ {
51+ default_user_pixbuf = gdk_pixbuf_new_from_file (value, &error);
52+ if (!default_user_pixbuf)
53+ {
54+ g_warning ("Failed to load default user image: %s", error->message);
55+ g_clear_error (&error);
56+ }
57+ }
58+ g_free (value);
59+ }
60+
61 /* Clock */
62 gtk_widget_set_visible(GTK_WIDGET(clock_label),
63 g_key_file_get_boolean (config, "greeter", "show-clock", NULL));

Subscribers

People subscribed via source and target branches