Merge lp:~kalebral-deactivatedaccount/drizzle/705699 into lp:drizzle/7.0

Proposed by Lee Bieber
Status: Merged
Approved by: Brian Aker
Approved revision: 2102
Merged at revision: 2110
Proposed branch: lp:~kalebral-deactivatedaccount/drizzle/705699
Merge into: lp:drizzle/7.0
Diff against target: 70 lines (+21/-11)
4 files modified
plugin/rabbitmq/admin.sh (+14/-2)
plugin/rabbitmq/plugin.ac (+3/-2)
plugin/rabbitmq/tests/t/variables-master.sh (+2/-7)
plugin/rabbitmq/tests/t/variables.test (+2/-0)
To merge this branch: bzr merge lp:~kalebral-deactivatedaccount/drizzle/705699
Reviewer Review Type Date Requested Status
Monty Taylor Approve
Review via email: mp+47169@code.launchpad.net

Description of the change

Fixes first part of 705699, don't sudo to start and stop rabbitmq server

To post a comment you must log in.
Revision history for this message
Monty Taylor (mordred) wrote :

Looks good.

review: Approve
2103. By Lee Bieber <email address hidden>

Fixes second part of the bug, don't build the plugin unless you have both the client and the server

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugin/rabbitmq/admin.sh'
2--- plugin/rabbitmq/admin.sh 2011-01-12 23:00:17 +0000
3+++ plugin/rabbitmq/admin.sh 2011-01-24 23:11:40 +0000
4@@ -34,14 +34,26 @@
5 export RABBITMQ_NODENAME="drizzle_test"
6 export RABBITMQ_NODE_IP_ADDRESS="0.0.0.0"
7
8+DIR=$RABBITMQ_NODENAME
9+rm -rf $DIR
10+mkdir -p $DIR/logs
11+mkdir $DIR/mnesia
12+
13+export RABBITMQ_MNESIA_BASE="`pwd`/$DIR/mnesia"
14+export RABBITMQ_LOG_BASE="`pwd`/$DIR/logs"
15+
16+
17 startup()
18 {
19- /usr/sbin/rabbitmq-server -detached
20+ /usr/lib/rabbitmq/bin/rabbitmq-server -detached
21+ sleep 5
22 }
23
24 shutdown()
25 {
26- /usr/sbin/rabbitmqctl stop
27+ /usr/lib/rabbitmq/bin/rabbitmqctl -q -n $RABBITMQ_NODENAME stop
28+ sleep 5
29+ rm -rf $DIR
30 }
31
32 restart()
33
34=== modified file 'plugin/rabbitmq/plugin.ac'
35--- plugin/rabbitmq/plugin.ac 2010-02-06 20:18:39 +0000
36+++ plugin/rabbitmq/plugin.ac 2011-01-24 23:11:40 +0000
37@@ -13,6 +13,7 @@
38 [
39 amqp_new_connection();
40 ])
41-AS_IF([test "$ac_cv_librabbitmq" = "no"],
42- [AC_MSG_WARN([Couldn't find rabbitmq c client support, rabbitmq log will not be built.])])
43+AC_PATH_PROG([RABBITMQ_BINARY],[rabbitmq-server],[no],[/usr/sbin:$PATH])
44+AS_IF([test "$ac_cv_librabbitmq" = "no" -o "x${RABBITMQ_BINARY}" = "xno"],
45+ [AC_MSG_WARN([Couldn't find both rabbitmq c client and server support, rabbitmq plugin will not be built.])])
46
47
48=== modified file 'plugin/rabbitmq/tests/t/variables-master.sh'
49--- plugin/rabbitmq/tests/t/variables-master.sh 2011-01-14 06:36:12 +0000
50+++ plugin/rabbitmq/tests/t/variables-master.sh 2011-01-24 23:11:40 +0000
51@@ -1,9 +1,4 @@
52 #! /bin/sh
53
54-echo "RABBITMQ_NODE_ PORT = $RABBITMQ_NODE_PORT"
55-echo "Stopping rabbitmq"
56-sudo -E $TOP_SRCDIR/plugin/rabbitmq/admin.sh stop
57-sleep 5
58-echo "Starting rabbitmq"
59-sudo -E $TOP_SRCDIR/plugin/rabbitmq/admin.sh start
60-sleep 5
61+$TOP_SRCDIR/plugin/rabbitmq/admin.sh stop
62+$TOP_SRCDIR/plugin/rabbitmq/admin.sh start
63
64=== modified file 'plugin/rabbitmq/tests/t/variables.test'
65--- plugin/rabbitmq/tests/t/variables.test 2010-09-22 14:17:17 +0000
66+++ plugin/rabbitmq/tests/t/variables.test 2011-01-24 23:11:40 +0000
67@@ -1,1 +1,3 @@
68 SELECT * FROM data_dictionary.modules WHERE module_name = 'rabbitmq';
69+
70+--exec $TOP_SRCDIR/plugin/rabbitmq/admin.sh stop

Subscribers

People subscribed via source and target branches