Merge lp:~kalebral-deactivatedaccount/drizzle-automation/verbose-crashme into lp:drizzle-automation

Proposed by Lee Bieber
Status: Merged
Merged at revision: 213
Proposed branch: lp:~kalebral-deactivatedaccount/drizzle-automation/verbose-crashme
Merge into: lp:drizzle-automation
Diff against target: 14 lines (+2/-2)
1 file modified
drizzle/automation/crashme/run.py (+2/-2)
To merge this branch: bzr merge lp:~kalebral-deactivatedaccount/drizzle-automation/verbose-crashme
Reviewer Review Type Date Requested Status
Patrick Crews Approve
Review via email: mp+39760@code.launchpad.net

Description of the change

add --verbose and --debug options to give me detail in case of test failures

To post a comment you must log in.
Revision history for this message
Patrick Crews (patrick-crews) wrote :

Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'drizzle/automation/crashme/run.py'
2--- drizzle/automation/crashme/run.py 2010-09-20 19:26:16 +0000
3+++ drizzle/automation/crashme/run.py 2010-11-01 17:04:48 +0000
4@@ -160,8 +160,8 @@
5 output_file.flush()
6 output_file.close()
7
8- logging.info("Running crash-me --server=%s --dir=limits-%s --connect-options=port=%d --force" % (server_name, variables['bzr_revision'], server.getPort()))
9- crashme_options= "--server=%s --connect-options=port=%d --force --dir=limits-%s " % (server_name, server.getPort(), variables['bzr_revision'])
10+ crashme_options= "--server=%s --connect-options=port=%d --force --dir=limits-%s --verbose --debug" % (server_name, server.getPort(), variables['bzr_revision'])
11+ logging.info("Running crash-me %s" % (crashme_options))
12 (retcode, output)= commands.getstatusoutput("./crash-me %s " % (crashme_options))
13 if retcode != 0:
14 logging.error("Failed to run crash-me. Got error %d:\n%s." % (retcode,output))

Subscribers

People subscribed via source and target branches

to all changes: