Merge ~kajiya/+git/gce-compute-image-packages:update-noble-to-20240607.00 into ~ubuntu-core-dev/+git/gce-compute-image-packages:ubuntu/noble

Proposed by Chloé Smith
Status: Merged
Merged at revision: cd86a3537db7686b28562c0276cecba690051be4
Proposed branch: ~kajiya/+git/gce-compute-image-packages:update-noble-to-20240607.00
Merge into: ~ubuntu-core-dev/+git/gce-compute-image-packages:ubuntu/noble
Diff against target: 135 lines (+59/-1)
8 files modified
debian/changelog (+12/-0)
packaging/debian/control (+1/-0)
packaging/debian/install (+2/-0)
packaging/google-compute-engine.spec (+1/-0)
src/etc/NetworkManager/dispatcher.d/google_hostname.sh (+18/-0)
src/usr/bin/google_set_hostname (+5/-0)
src/usr/bin/google_set_multiqueue (+2/-1)
src/usr/lib/networkd-dispatcher/routable.d/google_hostname.sh (+18/-0)
Reviewer Review Type Date Requested Status
Utkarsh Gupta Approve
Review via email: mp+470202@code.launchpad.net

Commit message

* d/ch entry for noble (LP: #2073164)
* Merge branch 'ubuntu-core-dev/ubuntu/master' into 'ubuntu-core-dev/ubuntu/noble'

To post a comment you must log in.
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Thank you, this is straightforward!

Sponsored:

$ dput ubuntu ../gce-compute-image-packages_20240607.00-0ubuntu1\~24.04.0_source.changes
Uploading gce-compute-image-packages using ftp to ubuntu (host: upload.ubuntu.com; directory: /ubuntu)
running supported-distribution: check whether the target distribution is currently supported (using distro-info)
{'allowed': ['release', 'proposed', 'backports', 'security'], 'known': ['release', 'proposed', 'updates', 'backports', 'security']}
running required-fields: check whether a field is present and non-empty in the changes file
running checksum: verify checksums before uploading
running suite-mismatch: check the target distribution for common errors
running check-debs: makes sure the upload contains a binary package
running gpg: check GnuPG signatures before the upload
Uploading gce-compute-image-packages_20240607.00-0ubuntu1~24.04.0.dsc
Uploading gce-compute-image-packages_20240607.00.orig.tar.xz
Uploading gce-compute-image-packages_20240607.00-0ubuntu1~24.04.0.debian.tar.xz
Uploading gce-compute-image-packages_20240607.00-0ubuntu1~24.04.0_source.buildinfo
Uploading gce-compute-image-packages_20240607.00-0ubuntu1~24.04.0_source.changes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 4841351..292c9b9 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,15 @@
6+gce-compute-image-packages (20240607.00-0ubuntu1~24.04.0) noble; urgency=medium
7+
8+ * No-change rebuild for Noble Numbat (LP: #2073164)
9+
10+ -- Chloé 'kajiya' Smith <chloe.smith@canonical.com> Fri, 26 Jul 2024 15:47:14 +0100
11+
12+gce-compute-image-packages (20240607.00-0ubuntu1) oracular; urgency=medium
13+
14+ * New upstream version 20240607.00. (LP: #2073164)
15+
16+ -- Chloé 'kajiya' Smith <chloe.smith@canonical.com> Mon, 15 Jul 2024 18:33:54 +0100
17+
18 gce-compute-image-packages (20240307.00-0ubuntu1~24.04.0) noble; urgency=medium
19
20 * Rebuild for Noble. (LP: #2066314)
21diff --git a/packaging/debian/control b/packaging/debian/control
22index 9bf6f87..6dc622f 100644
23--- a/packaging/debian/control
24+++ b/packaging/debian/control
25@@ -11,6 +11,7 @@ Architecture: all
26 Depends: google-compute-engine-oslogin,
27 google-guest-agent,
28 nvme-cli,
29+ networkd-dispatcher,
30 ${misc:Depends}
31 Recommends: rsyslog | system-log-daemon
32 Provides: irqbalance
33diff --git a/packaging/debian/install b/packaging/debian/install
34index 700a686..90f845d 100644
35--- a/packaging/debian/install
36+++ b/packaging/debian/install
37@@ -2,6 +2,8 @@ etc/apt/apt.conf.d/*
38 etc/modprobe.d/*
39 etc/rsyslog.d/*
40 etc/sysctl.d/*
41+etc/NetworkManager/dispatcher.d/*
42+usr/lib/networkd-dispatcher/*
43 lib/udev/rules.d/*
44 lib/udev/*
45 usr/bin/*
46diff --git a/packaging/google-compute-engine.spec b/packaging/google-compute-engine.spec
47index 956303d..4822c7f 100644
48--- a/packaging/google-compute-engine.spec
49+++ b/packaging/google-compute-engine.spec
50@@ -59,6 +59,7 @@ cp -a src/lib/dracut/* %{buildroot}/%{dracutdir}/
51 %defattr(0644,root,root,0755)
52 %attr(0755,-,-) %{_bindir}/*
53 %attr(0755,-,-) /etc/dhcp/dhclient.d/google_hostname.sh
54+%attr(0755,-,-) /etc/NetworkManager/dispatcher.d/google_hostname.sh
55 %{_udevrulesdir}/*
56 %attr(0755,-,-) %{_udevrulesdir}/../google_nvme_id
57 %config /etc/dracut.conf.d/*
58diff --git a/src/etc/NetworkManager/dispatcher.d/google_hostname.sh b/src/etc/NetworkManager/dispatcher.d/google_hostname.sh
59new file mode 100755
60index 0000000..7ff5376
61--- /dev/null
62+++ b/src/etc/NetworkManager/dispatcher.d/google_hostname.sh
63@@ -0,0 +1,18 @@
64+#!/bin/bash
65+# Copyright 2024 Google LLC.
66+#
67+# Licensed under the Apache License, Version 2.0 (the "License");
68+# you may not use this file except in compliance with the License.
69+# You may obtain a copy of the License at
70+#
71+# http://www.apache.org/licenses/LICENSE-2.0
72+#
73+# Unless required by applicable law or agreed to in writing, software
74+# distributed under the License is distributed on an "AS IS" BASIS,
75+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
76+# See the License for the specific language governing permissions and
77+# limitations under the License.
78+if [[ $2 == "up" ]]; then
79+ new_host_name=$DHCP4_HOST_NAME new_ip_address=${DHCP4_IP_ADDRESS%%/*} google_set_hostname
80+fi
81+
82diff --git a/src/usr/bin/google_set_hostname b/src/usr/bin/google_set_hostname
83index 05a0412..78c9fc4 100755
84--- a/src/usr/bin/google_set_hostname
85+++ b/src/usr/bin/google_set_hostname
86@@ -59,6 +59,11 @@ if [ -n "$new_host_name" ] && [ "${new_host_name%%.*}" != "$old_hostname" ] && !
87 nmcli general hostname "${new_host_name%%.*}"
88 fi
89
90+ hostnamectl=$(which hostnamectl 2> /dev/null)
91+ if [ -x "$hostnamectl" ]; then
92+ hostnamectl hostname "${new_host_name%%.*}"
93+ fi
94+
95 # Restart rsyslog to update the hostname.
96 systemctl=$(which systemctl 2> /dev/null)
97 if [ -x "$systemctl" ]; then
98diff --git a/src/usr/bin/google_set_multiqueue b/src/usr/bin/google_set_multiqueue
99index 8e51934..70eca28 100755
100--- a/src/usr/bin/google_set_multiqueue
101+++ b/src/usr/bin/google_set_multiqueue
102@@ -105,7 +105,8 @@ function is_a3_platform() {
103
104 [[ "$machine_type" == *"a3-highgpu-8g"* \
105 || "$machine_type" == *"a3-ultragpu-8g"* \
106- || "$machine_type" == *"a3-megagpu-8g"* ]] || return 1
107+ || "$machine_type" == *"a3-megagpu-8g"* \
108+ || "$machine_type" == *"a3-edge-8g"* ]] || return 1
109
110 return 0
111 }
112diff --git a/src/usr/lib/networkd-dispatcher/routable.d/google_hostname.sh b/src/usr/lib/networkd-dispatcher/routable.d/google_hostname.sh
113new file mode 100755
114index 0000000..656976a
115--- /dev/null
116+++ b/src/usr/lib/networkd-dispatcher/routable.d/google_hostname.sh
117@@ -0,0 +1,18 @@
118+#!/bin/bash
119+# Copyright 2024 Google LLC.
120+#
121+# Licensed under the Apache License, Version 2.0 (the "License");
122+# you may not use this file except in compliance with the License.
123+# You may obtain a copy of the License at
124+#
125+# http://www.apache.org/licenses/LICENSE-2.0
126+#
127+# Unless required by applicable law or agreed to in writing, software
128+# distributed under the License is distributed on an "AS IS" BASIS,
129+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
130+# See the License for the specific language governing permissions and
131+# limitations under the License
132+
133+new_host_name=$(curl -H 'Metadata-Flavor: Google' http://169.254.169.254/computeMetadata/v1/instance/hostname)
134+new_ip_address=$ADDR new_host_name=$new_host_name google_set_hostname
135+

Subscribers

People subscribed via source and target branches