Merge lp:~kaijanmaki/indicator-sound/lp-850662 into lp:indicator-sound/fourth
Proposed by
Antti Kaijanmäki
Status: | Merged |
---|---|
Approved by: | Ted Gould |
Approved revision: | 274 |
Merged at revision: | 274 |
Proposed branch: | lp:~kaijanmaki/indicator-sound/lp-850662 |
Merge into: | lp:indicator-sound/fourth |
Diff against target: |
36 lines (+12/-0) 1 file modified
src/pulseaudio-mgr.c (+12/-0) |
To merge this branch: | bzr merge lp:~kaijanmaki/indicator-sound/lp-850662 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ted Gould (community) | Approve | ||
Review via email: mp+78817@code.launchpad.net |
Description of the change
Please, review my fix for #850662. (this time agains right branch..)
PulseAudio indices are unsigned integers.
indicator-sound uses gint internally.
I noticed with GDB that the index value is set -1 when PA dies. Without the
fix PA functions are called with invalid indices.
I suspect that the true problem behind SIGABRT is that the pa_context is in
some broken state due to PA dying and passing it to any pa-function would
probably lead to a crash. Didn't investigate this further as checking the
index is enough to prevent the call to pa-functions.
To post a comment you must log in.
I tested the patch by attaching to the indicator- sound-service with GDB and then killing pulseaudio and clicking the indicator when PA was down. Everything worked great and no regression noticed on my side.