Merge lp:~kai-mast/friends/upstart2 into lp:friends

[Kai Mast]

Cleaned up the upstart changes.

Btw, how is the service currently started? Friends-app does it somehow. Is it done in the QML components? Is this even allowed when an app is confined?
This should not be needed anymore now. If it still needed for some reason the app should call "start friends", so it is tracked by upstart.

[lp:~kai-mast/friends/upstart2]

250. By Kai Mast on 2013-12-17

converted tabs to spaces

[Robert Bruce Park (robru)]

Looks good to me, but I want to get ken's input on this.

review: Approve

[Kai Mast (kai-mast)]

Another thing is, this means that friends starts on session start. I really like this behaviour, so I get notifications instantly and don't have to start the app.
However, some people may not like this. So, maybe we should introduce a setting that changes this behaviour.

[Kai Mast (kai-mast)]

One more thing :D We could also do logging via upstart. Basically friends just has to output to stdout/stderr and everything will end up in ~/.cache/upstart/friends.log

Maybe this could eliminate some logging code.

[Robert Bruce Park (robru)]

Reducing the amount of logging code sounds nice, but i'm not sure how much we'd really save. Changing all the "log.info" calls to print statements would be pointless, but I guess there's a couple lines to save by dropping the logfile and logging to stdout only. Submit a branch ;-)

[Ken VanDine (ken-vandine)]

I don't think we should automatically start the service unconditionally. For example if there are no accounts configured, it would add startup overhead when the session starts for no benefit. Maybe use the dconf bridge and start if a key is set to true. We can default to false, and let users enable it.

review: Needs Fixing

[Robert Bruce Park (robru)]

Ken, the problem with not autostarting is that dbus activation is resulting in the service activating at unfortunate times. Popey filed a bug in which apparently the video player has some kind of social integration, so after booting, the first time you try to watch a video, instead you're bombarded with friends' notifications. it's probably better to bombard with notifications at startup than at video-play time ;-)

[Kai Mast (kai-mast)]

Maybe we could start some small script at bootup that checks if a social media account is set up. If yes it emits a signal to start friends?

I need to investigate if this is possible with upstart.

[Robert Bruce Park (robru)]

Such a script should be relatively trivial. Just write it in a language with gobject support (eg, python, not bash) and then you can easily check for which accounts are present. launching friends is even easier, just call it's dbus Refresh method and dbus will launch it for us.

Then just change your upstart script to run this new script instead of friends itself.

[Robert Bruce Park (robru)]

Rejecting because Friends is disaled, sorry.

review: Disapprove

Unmerged revisions

250. By Kai Mast on 2013-12-17

converted tabs to spaces

249. By Kai Mast on 2013-12-17

Cleaned up upstart changes

=== added file 'data/friends.conf'
--- data/friends.conf	1970-01-01 00:00:00 +0000
+++ data/friends.conf	2013-12-17 21:53:44 +0000
@@ -0,0 +1,5 @@
+start on desktop-start
+stop on desktop-end
+
+exec friends-service
+

=== modified file 'debian/control'
--- debian/control	2013-11-07 14:54:31 +0000
+++ debian/control	2013-12-17 21:53:44 +0000
@@ -32,7 +32,7 @@
                valac,
                libdee-dev,
                dh-autoreconf,
-Standards-Version: 3.9.3
+Standards-Version: 3.9.4
 Homepage: https://launchpad.net/friends
 # If you aren't a member of ~super-friends but need to upload packaging changes,
 # just go ahead.  ~super-friends will notice and sync up the code again.

=== modified file 'debian/friends.install'
--- debian/friends.install	2013-04-04 22:57:10 +0000
+++ debian/friends.install	2013-12-17 21:53:44 +0000
@@ -2,3 +2,4 @@
 usr/share/dbus-1/services/com.canonical.Friends.Service.service
 usr/share/friends/model-schema.csv
 usr/share/glib-2.0/schemas/com.canonical.friends.gschema.xml
+usr/share/upstart/sessions/friends.conf

=== modified file 'setup.py'
--- setup.py	2013-04-04 22:57:10 +0000
+++ setup.py	2013-12-17 21:53:44 +0000
@@ -36,6 +36,8 @@
          ['data/com.canonical.friends.gschema.xml']),
         ('/usr/share/friends',
          ['data/model-schema.csv']),
+        ('/usr/share/upstart/sessions',
+        ['data/friends.conf'])
         ],
     entry_points = {
         'console_scripts': ['friends-dispatcher = friends.main:main'],