Merge lp:~kai-mast/friends-app/lp1168926 into lp:friends-app

[Kai Mast]

Remember which services the user wants to post to.

OMG that was so much more complicat ed than I thought. Why do javascript arrays behave so weird?

But should work now :)

[Robert Bruce Park (robru)]

I'm afraid this isn't working for me. if I disable facebook, then close and relaunch, it remembers to disable facebook. but I can never disable twitter. if I disable everything, then twitter is selected on next startup, and if I choose facebook but disable twitter, then theyre both enabled on next launch.

review: Needs Fixing

[Kai Mast (kai-mast)]

So strange. I just tested this again and it works completely fine for me.

Could you maybe remove your friends-app settings (.local/share/friends-app/friends-app-settings.u1db) and try again?

[Robert Bruce Park (robru)]

Hey Kai, sorry for the long delay in testing this. Release was totally hectic, but I've got some more time now ;-)

Unfortunately after deleting that file I still get the same issue. The only way I can get it to remember the state for my twitter account is to disable my facebook account entirely.

How many accounts do you have that you're testing with? When I have two accounts, it just does not remember the state for Twitter, which is second in the list.

[Kai Mast (kai-mast)]

Mh I also have two accounts. This is really strange.. maybe I should test in a virtual machine or something...

Unmerged revisions

144. By Kai Mast on 2014-02-18

FINALLY WORKS

143. By Kai Mast on 2014-02-18

First attempt

=== modified file 'qml/Post.qml'
--- qml/Post.qml	2014-02-17 17:42:00 +0000
+++ qml/Post.qml	2014-02-18 19:29:30 +0000
@@ -94,15 +94,21 @@
                 var serviceName = accountService.service.displayName;
                 var features = friends.featuresForProtocol(serviceName.toLowerCase().replace(".",""));
                 if (features.indexOf("send") > -1) {
+                    var sendEnabled = true
+
+                    // Take value from settings if exists
+                    if(sendEnabledSetting.value[i] != null)
+                        sendEnabled = sendEnabledSetting.value[i]
+
                     console.log (serviceName + " Supports send");
                     /* FIXME: we should get the iconName and serviceName from the accountService
                        but I am not sure we can access that from JS */
                     accountsModel.append({
                                              "displayName": displayName,
-                                             "id": accountId,
+                                             "accountId": accountId,
                                              "provider": serviceName,
                                              "accountIcon": iconName,
-                                             "sendEnabled": true
+                                             "sendEnabled": sendEnabled
                                          });
                 }
             }
@@ -153,8 +159,15 @@
                 control: CheckBox {
                     id: sw
                     checked: sendEnabled
+
                     onCheckedChanged: {
-                        accountsModel.setProperty(index, "sendEnabled", sw.checked);
+                        if(sendEnabledSetting.ready) {
+                            var newval = sendEnabledSetting.value
+                            newval[index] = sw.checked
+                            sendEnabledSetting.value = newval
+                        }
+
+                        accountsModel.setProperty(index, "sendEnabled", sw.checked)
                     }
                 }
 
@@ -163,6 +176,21 @@
         }
     }
 
+    SettingsProperty {
+        id: sendEnabledSetting
+        database: settingsStorage
+
+        name: "accounts-send-enabled"
+
+        defaultValue: {
+            var result = []
+
+            for(var i = 0; i < accounts.count; ++i)
+                result[i] = true
+
+            return result
+        }
+    }
     Component {
         id: errorPopover
         Popover {

=== modified file 'qml/SettingsProperty.qml'
--- qml/SettingsProperty.qml	2014-01-06 15:19:11 +0000
+++ qml/SettingsProperty.qml	2014-02-18 19:29:30 +0000
@@ -11,8 +11,14 @@
     //Must be variant so we can use any datatype
     property variant value: false
 
+    //Is the component ready to be used?
+    property bool ready: false
+
     // A little hack so value can be used like a normal property
     Component.onCompleted : {
+        if(database == null)
+            console.error("Settings Property '" + name + "' doesn't have a valid database")
+
         if(propertyStorage.contents !== undefined)
             value = propertyStorage.contents.value
         else {
@@ -20,9 +26,16 @@
             // This will create the database (with onValueChanged
             value = defaultValue
         }
+
+        ready = true
+        propertyLoaded()
     }
 
+    signal propertyLoaded
+
     onValueChanged: {
+        console.log("Settings Property '" + name + "' changed")
+
         // There is a "bug" that forces us to set it like this
         propertyStorage.contents = { "value": value }
     }