Merge lp:~kaaloo/charms/precise/elasticsearch/trunk into lp:~charmers/charms/precise/elasticsearch/trunk

Proposed by Luis Arias
Status: Merged
Merged at revision: 27
Proposed branch: lp:~kaaloo/charms/precise/elasticsearch/trunk
Merge into: lp:~charmers/charms/precise/elasticsearch/trunk
Diff against target: 53 lines (+6/-6)
3 files modified
config.yaml (+4/-4)
hooks/install (+1/-1)
revision (+1/-1)
To merge this branch: bzr merge lp:~kaaloo/charms/precise/elasticsearch/trunk
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Approve
Review via email: mp+188226@code.launchpad.net

Description of the change

The default elasticsearch version for this charm was really old so I changed it to 0.90.3 which is the currently compatible version with latest logstash 1.2.1. I changed the download url for elasticsearch because they stopped using github for this a long time ago and now have a download area on elasticsearch.org. I updated the default checksum and also the checksum algorithm to sha1 because elasticsearch.org now provides these.

To post a comment you must log in.
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

Thanks for the update! This looks good to me +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2012-11-06 04:34:30 +0000
3+++ config.yaml 2013-09-29 13:37:56 +0000
4@@ -1,7 +1,7 @@
5 options:
6 version:
7 type: string
8- default: "0.19.10"
9+ default: "0.90.3"
10 description: |
11 This sets the elasticsearch version number that will be used.
12 If you're going to plug in logstash, make sure versions match.
13@@ -36,9 +36,9 @@
14 This sets the s3 bucket name for the elasticsearch s3 gateway.
15 checksum:
16 type: string
17- default: "1e32776a453b7947dc525c4b095b30ce"
18+ default: "24843192bee3afd19f5a958800e896153dbc3569"
19 description: |
20- MD5 checksum of elasticsearch download.
21+ SHA1 checksum of elasticsearch download.
22 checksumwrapper:
23 type: string
24 default: "450fcee5225cc4837e8b61eb64bcc2d2"
25@@ -46,7 +46,7 @@
26 MD5 checksum of elasticsearch service wrapper download.
27 downloadurl:
28 type: string
29- default: "https://github.com/downloads/elasticsearch/elasticsearch"
30+ default: "https://download.elasticsearch.org/elasticsearch/elasticsearch"
31 description: |
32 URL to download elasticsearch from.
33 zenmasters:
34
35=== modified file 'hooks/install'
36--- hooks/install 2012-11-11 18:34:00 +0000
37+++ hooks/install 2013-09-29 13:37:56 +0000
38@@ -22,7 +22,7 @@
39 # Download and checksum
40 juju-log "elasticsearch wrapper binary not found local ... download"
41 wget -q -O /tmp/elasticsearch-$VERSION.tar.gz "${DOWNLOADURL}/elasticsearch-$VERSION.tar.gz"
42- if [[ $(md5sum "/tmp/elasticsearch-$VERSION.tar.gz" | cut -d " " -f 1) != ${CHECKSUM} ]]; then
43+ if [[ $(sha1sum "/tmp/elasticsearch-$VERSION.tar.gz" | cut -d " " -f 1) != ${CHECKSUM} ]]; then
44 juju-log --log-level CRITICAL "Checksum of elasticsearch-$VERSION.tar.gz failed"
45 exit 1
46 fi
47
48=== modified file 'revision'
49--- revision 2012-06-19 09:49:47 +0000
50+++ revision 2013-09-29 13:37:56 +0000
51@@ -1,1 +1,1 @@
52-26
53+28

Subscribers

People subscribed via source and target branches

to all changes: