Merge snap-kubelet:gkk/configure-dont-restart into snap-kubelet:master

[George Kraft]

Don't restart kubelet(-eks) service during configure hook

This `snapctl restart` call was introduced in commit 6c89724 along with a number of other changes to fix LP:2012689. The restart call was added to align with behavior and examples from snapcraft documentation, but was not a core part of the fix.

As a consequence, every call to `snap set` now causes kubelet to start or restart, even if it was not running before. This created a new race condition in EKS images (LP:2023284) in which kubelet can start and register with Kubernetes before it is fully configured, leading user-specified options like --register-with-taints to be ignored.

To fix this, we can remove the `snapctl restart` call from the configure hook and revert to the old behavior where `snap start` or `snap restart` must be called explicitly after `snap set`. This should resolve the race condition for LP:2023284 while still preserving the most important parts of 6c89724.

[Kevin W Monroe (kwmonroe)]

yup, +1. the previous 4s restart delay and atomic args from lp:2012689 are maintained, while allowing for multiple 'snap sets' before start/restart.

review: Approve

diff --git a/snapcraft.yaml.in b/snapcraft.yaml.in
index 393b80e..98cec62 100644
--- a/snapcraft.yaml.in
+++ b/snapcraft.yaml.in
@@ -191,7 +191,6 @@ parts:
       # can't finish generating the configure hook until now, after args have
       # been added
       echo 'mv "$SNAP_DATA/args.tmp" "$SNAP_DATA/args"' >> meta/hooks/configure
-      echo 'snapctl restart "$SNAP_NAME.daemon"' >> meta/hooks/configure
 
       snapcraftctl build