Merge ~k-ubuntu-s/ubuntu/+source/ubiquity:fix/forget-oem-wifi into ubuntu/+source/ubiquity:ubuntu/devel

Proposed by Elias
Status: Needs review
Proposed branch: ~k-ubuntu-s/ubuntu/+source/ubiquity:fix/forget-oem-wifi
Merge into: ubuntu/+source/ubiquity:ubuntu/devel
Diff against target: 14 lines (+2/-1)
1 file modified
bin/oem-config-prepare (+2/-1)
Reviewer Review Type Date Requested Status
Nick Rosbrook (community) Needs Information
Canonical Foundations Team Pending
git-ubuntu import Pending
Review via email: mp+495820@code.launchpad.net

Description of the change

Forget saved Wifi connections created during OEM installation. This did show Wifi connection to end-users after the initial setup, including Wifi passwords.

To post a comment you must log in.
Revision history for this message
Nick Rosbrook (enr0n) wrote :

This needs some context. Is there a bug you are trying to fix here?

This should also probably be reviewed by Foundations, rather than being in the general sponsorship queue.

review: Needs Information
Revision history for this message
Elias (k-ubuntu-s) wrote :

My workflow is to install via the OEM installation method, and run a post-install script on every machine. Usually it's laptops, so I connect them to my home-Wifi because this way I can also make sure that Wifi is actually working for the person to receive the laptop. When I'm done, I run the "Prepare for shipping to end user" thing from desktop.

The bug is that the "Prepare for shipping to end user" does not wipe the saved Wifi connections, so people who receive this laptop will have my home Wifi saved in their brand new system.

How can I make sure this MR is in the correct queue?

Revision history for this message
Nick Rosbrook (enr0n) wrote (last edit ):

Okay, that certainly sounds like a valid issue to address. Please start by opening a bug report explaining that, and detail which releases are affected.

I suggest requesting another review (with the "Request a review" button above) and select canonical-foundations. That should put it in the Foundations queue to review.

Revision history for this message
Elias (k-ubuntu-s) wrote :

Unmerged commits

e055dd1... by Elias

Delete Wifi connections established during OEM setup

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/bin/oem-config-prepare b/bin/oem-config-prepare
2index fba5680..e633819 100755
3--- a/bin/oem-config-prepare
4+++ b/bin/oem-config-prepare
5@@ -26,7 +26,8 @@ if [ "$(id -u)" = 0 ]; then
6 rm -f /etc/NetworkManager/system-connections/*
7
8 # Potentially sensitive.
9- rm -f /home/oem/.ssh/known_hosts
10+ rm -f /home/oem/.ssh/known_hosts \
11+ /etc/netplan/90-*.yaml
12
13 cp -a /usr/lib/oem-config/oem-config.service /lib/systemd/system
14 cp -a /usr/lib/oem-config/oem-config.target /lib/systemd/system

Subscribers

People subscribed via source and target branches

to all changes: