Merge lp:~jwhite-codeweavers/unity-lens-applications/fix-916201.stable into lp:unity-lens-applications/0.4

Proposed by Jeremy White
Status: Approved
Approved by: Mikkel Kamstrup Erlandsen
Approved revision: 250
Proposed branch: lp:~jwhite-codeweavers/unity-lens-applications/fix-916201.stable
Merge into: lp:unity-lens-applications/0.4
Diff against target: 12 lines (+1/-1)
1 file modified
src/daemon.vala (+1/-1)
To merge this branch: bzr merge lp:~jwhite-codeweavers/unity-lens-applications/fix-916201.stable
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+89937@code.launchpad.net

Description of the change

Resubmit a proposed change to simply use the category to prevent colon and double underscore replacement on regular .desktop files. Fixes bug 916201.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Thanks for back porting this Jeremy. Looks fine (still :-))

review: Approve

Unmerged revisions

250. By Jeremy White

Do not perform : and __ replacement on regular application files, only
ones that come from searching via Software Center. Fixes bug 916201.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/daemon.vala'
2--- src/daemon.vala 2012-01-06 11:57:40 +0000
3+++ src/daemon.vala 2012-01-24 16:36:24 +0000
4@@ -628,7 +628,7 @@
5
6 /* S-C uses "app_name:desktop_id.desktop", get rid of the prefix */
7 int colon_pos = desktop_id.index_of (":");
8- if (colon_pos > 0)
9+ if (category == Category.AVAILABLE && colon_pos > 0)
10 {
11 desktop_id = desktop_id[colon_pos+1:desktop_id.length];
12 /* well it's still not real desktop_id, S-C converts slashes to "__"

Subscribers

People subscribed via source and target branches

to all changes: