Merge lp:~justinmcp/unity-webapps-linkedin/expand-site-matches into lp:unity-webapps-linkedin

Proposed by Justin McPherson
Status: Merged
Merged at revision: 66
Proposed branch: lp:~justinmcp/unity-webapps-linkedin/expand-site-matches
Merge into: lp:unity-webapps-linkedin
Diff against target: 6 lines (+1/-1)
1 file modified
manifest.json (+1/-1)
To merge this branch: bzr merge lp:~justinmcp/unity-webapps-linkedin/expand-site-matches
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
WebApps Pending
Review via email: mp+212354@code.launchpad.net

Commit message

Expand site matching for linkedin to include https: variant.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Robert Bruce Park (robru) wrote :

Aren't you missing "https://www.linkedin.com" (eg, without the /* at the end)?

Revision history for this message
Justin McPherson (justinmcp) wrote :

I've test, and it works correctly in the container without. If you find
different let me know and I'll add it.

Revision history for this message
Robert Bruce Park (robru) wrote :

Nah, I didn't test anything, it just looked like it was missing since you had http with and without /* but https only had /*. No worries.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'manifest.json'
2--- manifest.json 2013-03-26 15:43:55 +0000
3+++ manifest.json 2014-03-24 07:14:27 +0000
4@@ -1,1 +1,1 @@
5-{"includes":["http://www.linkedin.com/*","http://www.linkedin.com"],"requires":["utils.js"],"name":"LinkedIn","scripts":["LinkedIn.user.js"],"maintainer":"Webapps Team <webapps@lists.launchpad.net>","license":"GPL-3","manifest-version":"1.0","integration-version":"2.4.8","package-name":"LinkedIn","description":"Unity Webapp for LinkedIn","icons":{"128":"128/unity-webapps-linkedin.png","48":"48/unity-webapps-linkedin.png","52":"52/unity-webapps-linkedin.png","64":"64/unity-webapps-linkedin.png"},"domain":"linkedin.com","homepage":"http://www.linkedin.com"}
6+{"includes":["http://www.linkedin.com/*","http://www.linkedin.com","https://www.linkedin.com/*"],"requires":["utils.js"],"name":"LinkedIn","scripts":["LinkedIn.user.js"],"maintainer":"Webapps Team <webapps@lists.launchpad.net>","license":"GPL-3","manifest-version":"1.0","integration-version":"2.4.8","package-name":"LinkedIn","description":"Unity Webapp for LinkedIn","icons":{"128":"128/unity-webapps-linkedin.png","48":"48/unity-webapps-linkedin.png","52":"52/unity-webapps-linkedin.png","64":"64/unity-webapps-linkedin.png"},"domain":"linkedin.com","homepage":"http://www.linkedin.com"}

Subscribers

People subscribed via source and target branches

to all changes: