Merge lp:~justinmcp/unity-chromium-extension/13.10 into lp:unity-chromium-extension/13.10

Proposed by Justin McPherson on 2014-02-07
Status: Merged
Approved by: David Barth on 2014-02-11
Approved revision: 237
Merged at revision: 237
Proposed branch: lp:~justinmcp/unity-chromium-extension/13.10
Merge into: lp:unity-chromium-extension/13.10
Diff against target: 11 lines (+1/-1)
1 file modified
chromium-extension/manifest.json.in (+1/-1)
To merge this branch: bzr merge lp:~justinmcp/unity-chromium-extension/13.10
Reviewer Review Type Date Requested Status
Alexandre Abreu (community) Needs Information on 2014-02-11
David Barth (community) Approve on 2014-02-11
Robert Bruce Park (community) 2014-02-07 Approve on 2014-02-07
PS Jenkins bot (community) continuous-integration Approve on 2014-02-07
Review via email: mp+205391@code.launchpad.net

Commit message

Infobars support has moved to the stable channel of chromium. This means
support is not patched in the way it was previously, and it's now necessary for the extension to request use.

Description of the change

Infobars support has moved to the stable channel of chromium. This means
support is not patched in the way it was previously, and it's now necessary for
the extension to request use.

To post a comment you must log in.
Robert Bruce Park (robru) wrote :

Bah, this is way easier than I was expecting. Ok!

review: Approve
David Barth (dbarth) wrote :

Robert: I think this fix is very important. I will top-approve this branch: can you upload it to -proposed for a quick resolution of the problem. Thanks.

review: Approve
Alexandre Abreu (abreu-alexandre) wrote :

quick question: ... don't you also need to update the background.js page? doesn't it refer to chrome.experimental.infobars?

review: Needs Information
Justin McPherson (justinmcp) wrote :

@abreu-alexandre; Support was previously patched into the correct "namespace", so there is no need, good forward thinking :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'chromium-extension/manifest.json.in'
2--- chromium-extension/manifest.json.in 2013-09-19 16:19:40 +0000
3+++ chromium-extension/manifest.json.in 2014-02-07 15:42:21 +0000
4@@ -33,7 +33,7 @@
5 "page": "background-page.html"
6 },
7
8- "permissions": ["tabs", "http://*/*", "notifications"],
9+ "permissions": ["tabs", "http://*/*", "notifications", "infobars"],
10
11 "options_page": "options.html",
12

Subscribers

People subscribed via source and target branches

to all changes: