Merge lp:~justinmcp/media-hub/fix-allowed-uri-schemes into lp:media-hub/stable

Proposed by David Barth
Status: Superseded
Proposed branch: lp:~justinmcp/media-hub/fix-allowed-uri-schemes
Merge into: lp:media-hub/stable
Diff against target: 78 lines (+23/-6)
3 files modified
debian/changelog (+8/-0)
src/core/media/apparmor/ubuntu.cpp (+3/-1)
src/core/media/gstreamer/playbin.cpp (+12/-5)
To merge this branch: bzr merge lp:~justinmcp/media-hub/fix-allowed-uri-schemes
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Pending
Jim Hodapp code Pending
Review via email: mp+268341@code.launchpad.net

This proposal supersedes a proposal from 2015-08-18.

This proposal has been superseded by a proposal from 2015-08-18.

Commit message

Allow media-hub to process streams coming via HTTPS urls

Description of the change

Allow media-hub to process streams coming via HTTPS urls

To post a comment you must log in.
Revision history for this message
Jim Hodapp (jhodapp) wrote : Posted in a previous version of this proposal

Looks good, thanks.

review: Approve (code)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)

Unmerged revisions

151. By Justin McPherson

Add https to allowed URI schemes

150. By CI Train Bot Account

Releasing 3.1.0+15.10.20150724-0ubuntu1

149. By Alfonso Sanchez-Beato

Set gstreamer context directly instead of using gobject to communicate with the video sink.
Approved by: Jim Hodapp, PS Jenkins bot

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2015-07-10 18:12:22 +0000
3+++ debian/changelog 2015-08-18 15:19:08 +0000
4@@ -1,3 +1,11 @@
5+media-hub (3.1.0+15.10.20150724-0ubuntu1) wily; urgency=medium
6+
7+ [ Alfonso Sanchez-Beato (email Canonical) ]
8+ * Set gstreamer context directly instead of using gobject to communicate
9+ with the video sink.
10+
11+ -- CI Train Bot <ci-train-bot@canonical.com> Fri, 24 Jul 2015 14:54:21 +0000
12+
13 media-hub (3.1.0+15.10.20150710-0ubuntu1) wily; urgency=medium
14
15 [ CI Train Bot ]
16
17=== modified file 'src/core/media/apparmor/ubuntu.cpp'
18--- src/core/media/apparmor/ubuntu.cpp 2014-11-26 16:23:19 +0000
19+++ src/core/media/apparmor/ubuntu.cpp 2015-08-18 15:19:08 +0000
20@@ -177,7 +177,9 @@
21 {
22 return Result{true, "Client can access content in /usr/share/sounds"};
23 }
24- else if (parsed_uri.scheme == "http" || parsed_uri.scheme == "rtsp")
25+ else if (parsed_uri.scheme == "http" ||
26+ parsed_uri.scheme == "https" ||
27+ parsed_uri.scheme == "rtsp")
28 {
29 return Result{true, "Client can access streaming content"};
30 }
31
32=== modified file 'src/core/media/gstreamer/playbin.cpp'
33--- src/core/media/gstreamer/playbin.cpp 2015-06-12 18:14:05 +0000
34+++ src/core/media/gstreamer/playbin.cpp 2015-08-18 15:19:08 +0000
35@@ -28,15 +28,22 @@
36
37 namespace
38 {
39-void setup_video_sink_for_buffer_streaming(GstElement* video_sink)
40+void setup_video_sink_for_buffer_streaming(GstElement* pipeline)
41 {
42 // Get the service-side BufferQueue (IGraphicBufferProducer) and associate it with
43 // the SurfaceTextureClientHybris instance
44 IGBPWrapperHybris igbp = decoding_service_get_igraphicbufferproducer();
45 SurfaceTextureClientHybris stc = surface_texture_client_create_by_igbp(igbp);
46+
47 // Because mirsink is being loaded, we are definitely doing * hardware rendering.
48- surface_texture_client_set_hardware_rendering (stc, TRUE);
49- g_object_set (G_OBJECT (video_sink), "surface", static_cast<gpointer>(stc), static_cast<char*>(NULL));
50+ surface_texture_client_set_hardware_rendering(stc, TRUE);
51+
52+ GstContext *context = gst_context_new("gst.mir.MirContext", TRUE);
53+ GstStructure *structure = gst_context_writable_structure(context);
54+ gst_structure_set(structure, "gst_mir_context", G_TYPE_POINTER, stc, NULL);
55+
56+ /* Propagate context in pipeline (needed by amchybris and mirsink) */
57+ gst_element_set_context(pipeline, context);
58 }
59 }
60 #else // MEDIA_HUB_HAVE_HYBRIS_MEDIA_COMPAT_LAYER
61@@ -44,7 +51,7 @@
62 {
63 void setup_video_sink_for_buffer_streaming(GstElement*)
64 {
65- throw core::ubuntu::media::Player::Error::OutOfProcessBufferStreamingNotSupported{};
66+ throw core::ubuntu::media::Player::Errors::OutOfProcessBufferStreamingNotSupported{};
67 }
68 }
69 #endif // MEDIA_HUB_HAVE_HYBRIS_MEDIA_COMPAT_LAYER
70@@ -268,7 +275,7 @@
71 "No video sink configured for the current pipeline"
72 };
73
74- setup_video_sink_for_buffer_streaming(video_sink);
75+ setup_video_sink_for_buffer_streaming(pipeline);
76 }
77
78 void gstreamer::Playbin::set_volume(double new_volume)

Subscribers

People subscribed via source and target branches