Merge lp:~justinmcp/media-hub/1487925 into lp:media-hub

Proposed by Justin McPherson
Status: Merged
Approved by: Jim Hodapp
Approved revision: 151
Merged at revision: 151
Proposed branch: lp:~justinmcp/media-hub/1487925
Merge into: lp:media-hub
Diff against target: 14 lines (+3/-1)
1 file modified
src/core/media/apparmor/ubuntu.cpp (+3/-1)
To merge this branch: bzr merge lp:~justinmcp/media-hub/1487925
Reviewer Review Type Date Requested Status
Jim Hodapp (community) code Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+268861@code.launchpad.net

Commit message

Add https to allowed URI schemes for contained applications.

Description of the change

Add https to allowed URI schemes.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:151
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~justinmcp/media-hub/1487925/+merge/268861/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/media-hub-ci/376/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-amd64-ci/216
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-armhf-ci/216
        deb: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-armhf-ci/216/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/media-hub-vivid-i386-ci/216

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/media-hub-ci/376/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Looks good, thanks.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/core/media/apparmor/ubuntu.cpp'
2--- src/core/media/apparmor/ubuntu.cpp 2014-11-26 16:23:19 +0000
3+++ src/core/media/apparmor/ubuntu.cpp 2015-08-24 00:46:51 +0000
4@@ -177,7 +177,9 @@
5 {
6 return Result{true, "Client can access content in /usr/share/sounds"};
7 }
8- else if (parsed_uri.scheme == "http" || parsed_uri.scheme == "rtsp")
9+ else if (parsed_uri.scheme == "http" ||
10+ parsed_uri.scheme == "https" ||
11+ parsed_uri.scheme == "rtsp")
12 {
13 return Result{true, "Client can access streaming content"};
14 }

Subscribers

People subscribed via source and target branches