Merge lp:~justinkov/maas/ephemeral into lp:~maas-committers/maas/trunk
Proposed by
Justin Kovaric
Status: | Rejected |
---|---|
Rejected by: | MAAS Lander |
Proposed branch: | lp:~justinkov/maas/ephemeral |
Merge into: | lp:~maas-committers/maas/trunk |
Diff against target: |
620 lines (+289/-17) 17 files modified
src/maasserver/api/tests/test_ipranges.py (+29/-3) src/maasserver/bootresources.py (+7/-1) src/maasserver/forms_iprange.py (+4/-0) src/maasserver/models/bootresource.py (+22/-0) src/maasserver/models/node.py (+13/-1) src/maasserver/rpc/boot.py (+54/-0) src/maasserver/rpc/tests/test_boot.py (+56/-0) src/maasserver/testing/architecture.py (+6/-4) src/maasserver/testing/factory.py (+5/-3) src/maasserver/utils/osystems.py (+11/-0) src/provisioningserver/boot/pxe.py (+5/-1) src/provisioningserver/boot/tftppath.py (+2/-1) src/provisioningserver/drivers/osystem/__init__.py (+4/-1) src/provisioningserver/drivers/osystem/caringo.py (+45/-0) src/provisioningserver/kernel_opts.py (+1/-1) src/provisioningserver/rackdservices/tftp.py (+17/-1) src/provisioningserver/templates/pxe/config.ephemeral.amd64.generic.template (+8/-0) |
To merge this branch: | bzr merge lp:~justinkov/maas/ephemeral |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Blake Rouse (community) | Needs Fixing | ||
Mike Pontillo | Pending | ||
Review via email: mp+316056@code.launchpad.net |
This proposal supersedes a proposal from 2017-01-26.
Commit message
Add ability for an OS to be deployed ephemerally.
Description of the change
Ephemeral OS support.
To post a comment you must log in.
Unmerged revisions
- 5656. By Justin Kovaric <email address hidden> <email address hidden>
-
added comment
- 5655. By Justin Kovaric <email address hidden> <email address hidden>
-
more unit tests.
- 5654. By Justin Kovaric <email address hidden> <email address hidden>
-
more unit tests
- 5653. By Justin Kovaric <email address hidden> <email address hidden>
-
Added unit test to test ip range addition through api with form encoded data since Django has different ways of handling input.
- 5652. By Justin Kovaric <email address hidden> <email address hidden>
-
Unit test for new kparams attribute of boot resource file.
- 5651. By Justin Kovaric <email address hidden> <email address hidden>
-
changes from make lint run
- 5650. By Justin Kovaric <email address hidden> <email address hidden>
-
results of make format and make lint.
- 5649. By Justin Kovaric <email address hidden> <email address hidden>
-
Added comment.
- 5648. By Justin Kovaric <email address hidden> <email address hidden>
-
Fix so that ephemeral image doesn't boot from local on restart.
- 5647. By Justin Kovaric <email address hidden> <email address hidden>
-
removed check for root-dd (not needed)
Thanks for submitting this merge proposal.
I may not be the correct person to review this change, because I'm not sure I understand the goals for this code.
Overall, this branch looks okay, but there are some things that need fixing. I've made some comments inline below.
The MAAS team aims for 100% code coverage with unit tests, so you'll also need to add those before we can accept this branch.
Thanks for your time and effort on this. Let us know if you have questions.