Merge lp:~jury-verrigni/slingshot/fix-1636632 into lp:~elementary-pantheon/slingshot/trunk

Proposed by Jury Verrigni on 2017-01-02
Status: Rejected
Rejected by: David Hewitt on 2017-03-14
Proposed branch: lp:~jury-verrigni/slingshot/fix-1636632
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 20 lines (+2/-1)
1 file modified
src/Widgets/SearchView.vala (+2/-1)
To merge this branch: bzr merge lp:~jury-verrigni/slingshot/fix-1636632
Reviewer Review Type Date Requested Status
David Hewitt Disapprove on 2017-03-14
Corentin Noël 2017-01-02 Disapprove on 2017-01-28
Review via email: mp+313958@code.launchpad.net

Description of the change

Providing a link to the appcenter with the searched term.
Note that this depends on this merge-request https://code.launchpad.net/~jury-verrigni/appcenter/handle-search-via-uri-scheme

To post a comment you must log in.
Corentin Noël (tintou) wrote :

I don't think this is the right thing to do here. You're introducing hidden dependency to AppCenter when you can just use the libappstream library to search. Each AppStream Components has an unique id which can be given to AppCenter (or any software center) via the appstream:// URI.

review: Disapprove
David Hewitt (davidmhewitt) wrote :

This has now been implemented in an alternative way. Closing.

review: Disapprove

Unmerged revisions

712. By Jury Verrigni on 2017-01-02

Now providing search on the AppCenter if result is empty

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/SearchView.vala'
2--- src/Widgets/SearchView.vala 2016-12-28 16:13:57 +0000
3+++ src/Widgets/SearchView.vala 2017-01-02 09:59:19 +0000
4@@ -57,7 +57,7 @@
5 case SearchItem.ResultType.APP_ACTIONS:
6 case SearchItem.ResultType.LINK:
7 case SearchItem.ResultType.SETTINGS:
8- search_item.app.match.execute (null);
9+ search_item.app.match.execute (null);
10 break;
11 default:
12 search_item.app.launch ();
13@@ -151,6 +151,7 @@
14
15 stack.set_visible_child_name ("results");
16 } else {
17+ alert_view.description = _("Try changing terms or search the <a href=\"appstream://search/%s\">AppCenter</a>".printf (search_term));
18 alert_view.title = _("No Results for “%s”".printf (search_term));
19 stack.set_visible_child_name ("alert");
20 }

Subscribers

People subscribed via source and target branches