Merge lp:~junrrein/synapse-project/indicator-non-instant-search into lp:~elementary-apps/synapse-project/indicator-search

[Julián Unrrein]

Use Granite.Widgets.SeachBar instead of Gtk.Entry.

Use Granite.Widgets.SeachBar instead of Gtk.Entry.

This is how the indicator behaves in trunk -> http://videobin.org/+6ue/8bv.html.

Every time I press a letter key, the indicator starts searching, regardless of additional input. This makes it function slowly, and look wonky.

Also, notice that after clearing the entry, there are still search results being displayed.

This is how the indicator behaves in this branch -> http://videobin.org/+6ud/8bu.html

Granite's SearchBar triggers searching only when some time has passed since the last user input (300 milliseconds, in this case).

The indicator performs faster this way, and the results view is correctly cleared when the entry is empty.

[lp:~junrrein/synapse-project/indicator-non-instant-search]

527. By Julián Unrrein on 2013-08-29

Replace spaces with tabs.

[Tom Beckmann (tombeckmann)]

The branch is set to "work in progress" for now, I hope we can get a different solution than delaying the search going to make the indicator more stable. If not, we'll merge this branch instead.

Unmerged revisions

527. By Julián Unrrein on 2013-08-29

Replace spaces with tabs.

526. By Julián Unrrein on 2013-08-29

Use Granite.Widgets.SeachBar instead of Gtk.Entry.
This makes the indicator search after a certain time has passed since user input.

=== modified file 'src/indicator/menu.vala'
--- src/indicator/menu.vala	2013-08-21 08:54:19 +0000
+++ src/indicator/menu.vala	2013-08-29 03:44:22 +0000
@@ -11,9 +11,10 @@
 		reserve_toggle_size = false;
 		take_focus = true;
 
-		entry = new Gtk.Entry ();
+		entry = new Granite.Widgets.SearchBar ("");
+		(entry as Granite.Widgets.SearchBar).pause_delay = 300;
 
-		entry.primary_icon_name = "edit-find-symbolic";
+		//entry.primary_icon_name = "edit-find-symbolic";
 		entry_item = new MatchItem ("Search:", entry, true);
 		append (entry_item);
 
@@ -46,13 +47,20 @@
 					return true;
 				default:
 					entry.key_press_event (e);
-					if (entry.text == "")
+					/*if (entry.text == "")
 						clear ();
 					else
-						search (entry.text);
+						search (entry.text);*/
 					return true;
 			}
 		});
+		
+		(entry as Granite.Widgets.SearchBar).text_changed_pause.connect (() => {
+			if (entry.text == "")
+				clear ();
+			else
+				search (entry.text);
+		});
 
 		move_current.connect ((dir) => {
 			// see if the next item will be the search entry