elementary OS

Merge lp:~junrrein/elementaryos/add-sources into lp:~elementary-os/elementaryos/apport-retrace-sandbox

add-sources
Merge into apport-retrace-sandbox

Proposed by Julián Unrrein on 2013-07-02

Status:	Merged
Merged at revision:	32
Proposed branch:	lp:~junrrein/elementaryos/add-sources
Merge into:	lp:~elementary-os/elementaryos/apport-retrace-sandbox
Diff against target:	63 lines (+30/-2) 2 files modified Ubuntu 12.04/sources.list (+13/-0) elementary OS 0.2/sources.list (+17/-2)
To merge this branch:	bzr merge lp:~junrrein/elementaryos/add-sources
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Cody Garver (community)		2013-07-02	Approve on 2013-07-02
Sergey "Shnatsel" Davidoff (community)		2013-07-02	Abstain on 2013-07-02
Rico Tzschichholz			Needs Information on 2013-07-02
Review via email: mp+172454@code.launchpad.net

Commit message

Add origins for source packages for elementary OS 0.2 and Ubuntu 12.04.

Description of the change

Add origins for source packages for elementary OS 0.2 and Ubuntu 12.04.

This should prevent apport-retracer from complaining that there aren't any "deb-src" origins enabled.

lp:~junrrein/elementaryos/add-sources updated on 2013-07-02

33. By Julián Unrrein on 2013-07-02: Use non-local mirrors. Add missing origins.

Revision history for this message

Julián Unrrein (junrrein) wrote on 2013-07-02:

#

I just tried running apport-retrace with the "ddebs" mirrors, but it wasn't succesful, while it worked fine for my local "ar" mirrors.

lp:~junrrein/elementaryos/add-sources updated on 2013-07-02

34. By Julián Unrrein on 2013-07-02: Use mirrors that actually work.

Revision history for this message

Julián Unrrein (junrrein) wrote on 2013-07-02:

#

Updated with a mirror that actually works. Now I tested before pushing, I promise.

lp:~junrrein/elementaryos/add-sources updated on 2013-07-02

35. By Julián Unrrein on 2013-07-02: Fix a typo in the Ubuntu 12.04 sources list.

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2013-07-02:

#

Why does apport-retrace need deb-src origins in the first place?

review: Needs Information

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2013-07-02:

#

Also, ddebs are for -dbgsym packages only and at present are really hacky and ugly in Ubuntu.

Revision history for this message

Rico Tzschichholz (ricotz) wrote on 2013-07-02:

#

@shnatsel: Why are there still references to yorba and midori ppas? :\

review: Needs Information

Revision history for this message

Julián Unrrein (junrrein) wrote on 2013-07-02:

#

I don't know why apport-retrace needs deb-src origins. In my personal testing, it complained that there wasn't any. I added them, and it worked. I'm sorry I didn't investigate the problem further. But I don't know where to look at either.

Keep in mind that I am talking about apport from trunk.

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2013-07-02:

#

Ok, if the answer is "it doesn't work without these and I don't know why", I'm fine with that and I just defer to Cody who's into recent versions of Apport.

Rico: I believe Apport is capable of picking the corresponding version of debug symbols package even if it has several versions (and possibly a newer version) available. Midori and Yorba do not run their own retracers, so the crashes submitted by PPA testers are processed by ours. Hence the references to PPAs not used in the OS.

review: Abstain

Revision history for this message

Cody Garver (codygarver) wrote on 2013-07-02:

#

Makes message go away.

review: Approve

Revision history for this message

Rico Tzschichholz (ricotz) wrote on 2013-07-03:

#

@shnatsel: Alrigth

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Julián Unrrein

elementary OS team