Merge lp:~junaidali/charms/trusty/plumgrid-director/trunk into lp:~plumgrid-team/charms/trusty/plumgrid-director/trunk

Proposed by Junaid Ali
Status: Merged
Merged at revision: 30
Proposed branch: lp:~junaidali/charms/trusty/plumgrid-director/trunk
Merge into: lp:~plumgrid-team/charms/trusty/plumgrid-director/trunk
Diff against target: 77 lines (+17/-2)
3 files modified
hooks/pg_dir_hooks.py (+13/-1)
hooks/pg_dir_utils.py (+2/-0)
templates/kilo/00-pg.conf (+2/-1)
To merge this branch: bzr merge lp:~junaidali/charms/trusty/plumgrid-director/trunk
Reviewer Review Type Date Requested Status
Bilal Baqar Approve
Review via email: mp+291147@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Bilal Baqar (bbaqar) :
review: Approve
30. By Bilal Baqar

Adding status messages in charms - Ticket:[SOL-949]

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/pg_dir_hooks.py'
2--- hooks/pg_dir_hooks.py 2016-03-26 19:07:37 +0000
3+++ hooks/pg_dir_hooks.py 2016-04-06 18:38:01 +0000
4@@ -16,7 +16,8 @@
5 log,
6 config,
7 relation_set,
8- relation_ids
9+ relation_ids,
10+ status_set
11 )
12
13 from charmhelpers.fetch import (
14@@ -50,8 +51,10 @@
15 '''
16 Install hook is run when the charm is first deployed on a node.
17 '''
18+ status_set('maintenance', 'Executing pre-install')
19 load_iptables()
20 configure_sources(update=True)
21+ status_set('maintenance', 'Installing apt packages')
22 pkgs = determine_packages()
23 for pkg in pkgs:
24 apt_install(pkg, options=['--force-yes'], fatal=True)
25@@ -108,6 +111,7 @@
26 charm_config.changed('plumgrid-build') or
27 charm_config.changed('install_keys') or
28 charm_config.changed('iovisor-build')):
29+ status_set('maintenance', 'Upgrading apt packages')
30 stop_pg()
31 configure_sources(update=True)
32 pkgs = determine_packages()
33@@ -157,6 +161,14 @@
34 stop_pg()
35
36
37+@hooks.hook('update-status')
38+def update_status():
39+ if service_running('plumgrid'):
40+ status_set('active', 'Unit is ready')
41+ else:
42+ status_set('blocked', 'plumgrid service not running')
43+
44+
45 def main():
46 try:
47 hooks.execute(sys.argv)
48
49=== modified file 'hooks/pg_dir_utils.py'
50--- hooks/pg_dir_utils.py 2016-03-26 20:30:59 +0000
51+++ hooks/pg_dir_utils.py 2016-04-06 18:38:01 +0000
52@@ -17,6 +17,7 @@
53 log,
54 config,
55 unit_get,
56+ status_set
57 )
58 from charmhelpers.contrib.network.ip import (
59 get_iface_from_addr,
60@@ -160,6 +161,7 @@
61 raise ValueError("plumgrid service couldn't be started")
62 else:
63 raise ValueError("libvirt-bin service couldn't be started")
64+ status_set('active', 'Unit is ready')
65
66
67 def stop_pg():
68
69=== added symlink 'hooks/update-status'
70=== target is u'pg_dir_hooks.py'
71=== modified file 'templates/kilo/00-pg.conf'
72--- templates/kilo/00-pg.conf 2016-03-24 12:33:25 +0000
73+++ templates/kilo/00-pg.conf 2016-04-06 18:38:01 +0000
74@@ -1,1 +1,2 @@
75-$template ls_json,"{{'{'}}{{'%'}}timestamp:::date-rfc3339,jsonf:@timestamp%,%source:::jsonf:@source_host%,%msg:::json%}":syslogtag,isequal,"pg:" @{{ opsvm_ip }}:6000;ls_json
76+$template ls_json,"{{'{'}}{{'%'}}timestamp:::date-rfc3339,jsonf:@timestamp%,%source:::jsonf:@source_host%,%msg:::json%}"
77+:syslogtag,isequal,"pg:" @{{ opsvm_ip }}:6000;ls_json

Subscribers

People subscribed via source and target branches