Terminal

Merge lp:~julien-spautz/pantheon-terminal/no-new-window into lp:~elementary-apps/pantheon-terminal/trunk

  1. no-new-window
  2. Merge into trunk
Proposed by Julien Spautz
Status: Merged
Approved by: Cody Garver
Approved revision: 474
Merged at revision: 483
Proposed branch: lp:~julien-spautz/pantheon-terminal/no-new-window
Merge into: lp:~elementary-apps/pantheon-terminal/trunk
Diff against target: 11 lines (+1/-1)
1 file modified
src/PantheonTerminalWindow.vala (+1/-1)
To merge this branch: bzr merge lp:~julien-spautz/pantheon-terminal/no-new-window
Reviewer Review Type Date Requested Status
Cody Garver (community) Approve
Review via email: mp+162083@code.launchpad.net

Commit message

Temporarily disable dragging tabs to create new windows. Approved by Cody Garver.

Description of the change

Since bug #1157350 requires a break in granite, we might want to disable creating new windows by dragging tabs until granite is fixed. I think it's better to temporarily disable that feature as it inevitably results in a segfault.

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/PantheonTerminalWindow.vala'
2--- src/PantheonTerminalWindow.vala 2013-04-16 19:43:58 +0000
3+++ src/PantheonTerminalWindow.vala 2013-05-02 12:54:25 +0000
4@@ -148,7 +148,7 @@
5 notebook.show_icons = false;
6 notebook.tab_switched.connect (on_switch_page);
7 notebook.tab_moved.connect (on_tab_moved);
8- notebook.allow_new_window = true;
9+ notebook.allow_new_window = false;
10 notebook.allow_duplication = false;
11 notebook.margin_top = 3;
12

Subscribers

People subscribed via source and target branches