Merge lp:~julien-spautz/granite/1134672 into lp:~elementary-pantheon/granite/granite

Proposed by Julien Spautz
Status: Merged
Approved by: David Gomes
Approved revision: 540
Merged at revision: 540
Proposed branch: lp:~julien-spautz/granite/1134672
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 39 lines (+10/-8)
2 files modified
lib/Widgets/DecoratedWindow.vala (+9/-0)
lib/Widgets/LightWindow.vala (+1/-8)
To merge this branch: bzr merge lp:~julien-spautz/granite/1134672
Reviewer Review Type Date Requested Status
David Gomes (community) Approve
Review via email: mp+153880@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
David Gomes (davidgomes) :
review: Approve
Revision history for this message
David Gomes (davidgomes) wrote :

Good code, fixed the bug perfectly.

Good job!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/Widgets/DecoratedWindow.vala'
--- lib/Widgets/DecoratedWindow.vala 2013-01-14 20:26:07 +0000
+++ lib/Widgets/DecoratedWindow.vala 2013-03-18 17:30:37 +0000
@@ -235,6 +235,15 @@
235235
236 return on_close_button;236 return on_close_button;
237 }237 }
238
239 public override bool key_press_event (Gdk.EventKey event) {
240 if (event.keyval == Gdk.Key.Escape) {
241 this.delete_event (((Gdk.Event*) (&event))->any);
242 return true;
243 }
244
245 return base.key_press_event (event);
246 }
238247
239 private bool coords_over_close_button (double x, double y) {248 private bool coords_over_close_button (double x, double y) {
240 return this.deletable &&249 return this.deletable &&
241250
=== modified file 'lib/Widgets/LightWindow.vala'
--- lib/Widgets/LightWindow.vala 2013-01-01 23:46:39 +0000
+++ lib/Widgets/LightWindow.vala 2013-03-18 17:30:37 +0000
@@ -35,14 +35,7 @@
35 public LightWindow (string title = "") {35 public LightWindow (string title = "") {
36 base (title, StyleClass.CONTENT_VIEW_WINDOW, StyleClass.CONTENT_VIEW);36 base (title, StyleClass.CONTENT_VIEW_WINDOW, StyleClass.CONTENT_VIEW);
37 }37 }
3838
39 public override bool key_press_event (Gdk.EventKey event) {
40 if (event.keyval == Gdk.Key.Escape) {
41 this.delete_event (((Gdk.Event*) (&event))->any);
42 return true;
43 }
44 return base.key_press_event (event);
45 }
46 }39 }
4740
48}41}

Subscribers

People subscribed via source and target branches