Merge lp:~juliank/update-manager/remove-breaks into lp:update-manager

[Julian Andres Klode]

[Julian Andres Klode (juliank)]

I switched the order of checks because I figured Replaces will be shorter than Breaks+Conflicts.

[Julian Andres Klode (juliank)]

Arguably this maybe should only happen for unversioned Breaks, but also if you have a versioned Breaks: other (<< 2) because you took over a file from a package, and other=1 is installed, but other=2 was removed from the new release, then other=1 should be removed.

[Steve Langasek (vorlon)]

Approved, begrudgingly

review: Approve

Unmerged revisions

2948. By Julian Andres Klode on 2022-04-26

Allow removing packages on Replaces+Breaks in addition to
Replaces+Conflicts, as there are people using the former despite the
latter being documented in policy 7.6.2.

=== modified file 'UpdateManager/Core/MyCache.py'
--- UpdateManager/Core/MyCache.py	2019-04-08 17:00:30 +0000
+++ UpdateManager/Core/MyCache.py	2022-04-26 08:13:37 +0000
@@ -170,11 +170,11 @@
             candidate = cpkg.candidate
             if candidate is not None:
                 if (self._check_dependencies(
-                        target, candidate.get_dependencies("Conflicts"))
+                        target, candidate.get_dependencies("Replaces"))
                     and self._check_dependencies(
-                        target, candidate.get_dependencies("Replaces"))):
+                        target, candidate.get_dependencies("Conflicts", "Breaks"))):
                     logging.info(
-                        "%s Conflicts/Replaces %s; allowing removal" % (
+                        "%s Conflicts (or Breaks)/Replaces %s; allowing removal" % (
                             candidate.package.shortname, pkg.shortname))
                     return True
         return False

=== modified file 'debian/changelog'
--- debian/changelog	2022-04-11 07:58:43 +0000
+++ debian/changelog	2022-04-26 08:13:37 +0000
@@ -1,3 +1,11 @@
+update-manager (1:22.10.0) UNRELEASED; urgency=medium
+
+  * Allow removing packages on Replaces+Breaks in addition to
+    Replaces+Conflicts, as there are people using the former despite the
+    latter being documented in policy 7.6.2.
+
+ -- Julian Andres Klode <[e-mail]>  Tue, 26 Apr 2022 10:11:11 +0200
+
 update-manager (1:22.04.9) jammy; urgency=medium
 
   * Adjust dates in hwe-support-status for jammy.