Code review comment for ~juliank/ubuntu/+source/rust-sequoia-sqv:ubuntu/devel

Hi Julian,

thank you very much for getting sequoia in shape for Ubuntu! This generally LGTM and IMO is a good example of how we do Rust packaging in Ubuntu main. It follows best-practices from https://github.com/canonical/ubuntu-mir/blob/main/vendoring/Rust.md – especially the .orig-rust-vendor.tar.xz vendoring tarball.

A small nitpick (non-blocking): You might want to add a debian/README.source file, describing of how the vendoring tarball is created and how (vendored) dependencies can be updated. (Along the lines of https://git.launchpad.net/ubuntu/+source/s390-tools/tree/debian/README.source)

Another non-blocking nitpick can be found in-line below.

The one blocking issue I discovered is that it FTBFS with the following error:
[...]
  run pkg_config fail: Could not run `PKG_CONFIG_ALLOW_SYSTEM_CFLAGS=1 pkg-config --libs --cflags openssl`
  The pkg-config command could not be found.
[...]

Adding "pkgconf" as a B-D (to find openssl system lib) fixes this. And you should probably do that.

Once that pkg-config issue is fixed. Feel free to upload!