Merge lp:~juliank/ubuntu-release-upgrader/suggests-not-important into lp:ubuntu-release-upgrader

[Julian Andres Klode]

Do not consider Suggests important, so automatically installed packages
that are not recommended or dependend on anymore are removed across a
dist upgrade (LP: #1725861).

Not tested whether it actually works, but it seems reasonable to assume so. Not sure how to test it.

[Brian Murray (brian-murray)]

This seems fine, but I'm testing it on a system that's been upgraded over multiple releases which when manually using the setting will autoremove a number of packages.

[Brian Murray (brian-murray)]

The "Remove (was auto installed)" list includes packages I'd seen when using apt autoremove with the setting in effect before the upgrade so it seems like its doing the right thing.

Another involved way to test would be to install zesty, upgrade to artful and then ensure "ubuntu-wallpapers-zesty" was removed.

review: Approve

=== modified file 'DistUpgrade/DistUpgradeCache.py'
--- DistUpgrade/DistUpgradeCache.py	2016-12-22 00:02:04 +0000
+++ DistUpgrade/DistUpgradeCache.py	2018-03-19 14:27:00 +0000
@@ -145,6 +145,9 @@
             not "RELEASE_UPGRADE_NO_RECOMMENDS" in os.environ):
             apt_pkg.config.set("APT::Install-Recommends", "true")
 
+
+        apt_pkg.config.set("APT::AutoRemove::SuggestsImportant", "false")
+
     def _apply_dselect_upgrade(self):
         """ honor the dselect install state """
         for pkg in self:

=== modified file 'debian/changelog'
--- debian/changelog	2018-03-16 17:56:35 +0000
+++ debian/changelog	2018-03-19 14:27:00 +0000
@@ -1,3 +1,11 @@
+ubuntu-release-upgrader (1:18.04.12) UNRELEASED; urgency=medium
+
+  * Do not consider Suggests important, so automatically installed packages
+    that are not recommended or dependend on anymore are removed across a
+    dist upgrade (LP: #1725861)
+
+ -- Julian Andres Klode <[e-mail]>  Mon, 19 Mar 2018 15:19:12 +0100
+
 ubuntu-release-upgrader (1:18.04.11) bionic; urgency=medium
 
   * Check that a sources.list entry for the from distribution exists