Merge ~juliank/ubuntu-archive-tools:r-a-r-actually-check-queues-correctly into ubuntu-archive-tools:main

Proposed by Julian Andres Klode
Status: Merged
Merged at revision: 20cffa9158b42884019145a7bb93372c929985fc
Proposed branch: ~juliank/ubuntu-archive-tools:r-a-r-actually-check-queues-correctly
Merge into: ubuntu-archive-tools:main
Diff against target: 23 lines (+1/-4)
1 file modified
retry-autopkgtest-regressions (+1/-4)
Reviewer Review Type Date Requested Status
Steve Langasek Approve
Review via email: mp+463305@code.launchpad.net

Description of the change

Apparently the "skip retrying already queued items" part didn't actually work as it accidentally parsed the queue item "foo {...}" as "foo\n" and then tried to compare it with foo...

To post a comment you must log in.
Revision history for this message
Steve Langasek (vorlon) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/retry-autopkgtest-regressions b/retry-autopkgtest-regressions
2index f9b9f51..9ccbc9b 100755
3--- a/retry-autopkgtest-regressions
4+++ b/retry-autopkgtest-regressions
5@@ -23,7 +23,6 @@ from datetime import datetime, timedelta
6 import urllib.request
7 import urllib.parse
8 import argparse
9-import io
10 import lzma
11 import os
12 import re
13@@ -121,9 +120,7 @@ def already_triggered(release, arch, pkg, triggers, extra_params, running, queue
14 if not queue or not queue_arch == arch:
15 continue
16 for raw_item in queue:
17- buf = io.StringIO(raw_item)
18- queued_pkg = buf.readline()
19- item_params_raw = buf.readline()
20+ queued_pkg, item_params_raw = raw_item.split(None, 1)
21 if not item_params_raw:
22 # it was only one line
23 m = re.search('([^ ^{]*) (.*)', queued_pkg)

Subscribers

People subscribed via source and target branches