lp:~juliank/software-properties/add-apt-repository-run-update
- Get this branch:
- bzr branch lp:~juliank/software-properties/add-apt-repository-run-update
Branch merges
- Steve Langasek: Approve
- Balint Reczey: Approve
-
Diff: 58 lines (+25/-2)2 files modifiedadd-apt-repository (+19/-2)
debian/changelog (+6/-0)
Branch information
Recent revisions
- 1000. By Iain Lane
-
tests/test_dbus.py: Don't call GTK from multiple processes.
We started seeing software-properties tests failing with fatal X errors after
GTK 3.22.24 was uploaded. I think what happened was:
- the testsuite imports GTK (via GI)
- this import itself initialises GTK, retrieving the value of a load of
X atoms
- it forks to start software-properties- dbus in a separate process
- this process then accesses another X atom after we ask it to do stuff
- X doesn't like that and kills us
The testsuite is now rewritten to not fork. We start a separate *thread*
to run the D-Bus service in. A benefit of this is that we're more
asynchronous than we were before, so some of the tests are slightly
refactored to not run their own main loop but instead check that the
signal emission they're interested in has happened. (LP: #1721828) - 998. By Brian Murray
-
add-apt-repository: Don't raise a Traceback when Ctrl-c is used to cancel
an operation. Thanks to Launchpad user Yeison Valero fo the initial patch.
(LP: #1704508)
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:software-properties