MAAS

Merge lp:~julian-edwards/maas/remove-excessive-maclink-logging into lp:~maas-committers/maas/trunk

  1. remove-excessive-maclink-logging
  2. Merge into trunk
Proposed by Julian Edwards
Status: Merged
Approved by: Julian Edwards
Approved revision: no longer in the source branch.
Merged at revision: 2773
Proposed branch: lp:~julian-edwards/maas/remove-excessive-maclink-logging
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 12 lines (+0/-3)
1 file modified
src/maasserver/api/node_groups.py (+0/-3)
To merge this branch: bzr merge lp:~julian-edwards/maas/remove-excessive-maclink-logging
Reviewer Review Type Date Requested Status
Raphaël Badin (community) Needs Information
Julian Edwards (community) trivial Approve
Review via email: mp+231485@code.launchpad.net

Commit message

Remove excessive logging when a MAC is linked to a network.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) :
review: Approve (trivial)
Revision history for this message
Raphaël Badin (rvb) wrote :

Hang on, the logging was useful. Why did you remove the logging instead of first checking if the link was already there and if not, add the link and log?

review: Needs Information
Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Thursday 21 Aug 2014 16:52:32 you wrote:
> Review: Needs Information
>
> Hang on, the logging was useful. Why did you remove the logging instead of
> first checking if the link was already there and if not, add the link and
> log?

Because I decided that it wasn't that useful and I needed a quick fix :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/api/node_groups.py'
2--- src/maasserver/api/node_groups.py 2014-08-18 13:44:26 +0000
3+++ src/maasserver/api/node_groups.py 2014-08-20 01:47:06 +0000
4@@ -268,9 +268,6 @@
5 try:
6 network = Network.objects.get(ip=ipnetwork.ip.format())
7 network.macaddress_set.add(mac_address)
8- maaslog.info(
9- "Linking %s to network %s",
10- mac_address, network.name)
11 except Network.DoesNotExist:
12 pass
13