Merge lp:~julian-edwards/maas/mark-failed-twice into lp:~maas-committers/maas/trunk
Proposed by
Julian Edwards
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Julian Edwards | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 2969 | ||||
Proposed branch: | lp:~julian-edwards/maas/mark-failed-twice | ||||
Merge into: | lp:~maas-committers/maas/trunk | ||||
Diff against target: |
32 lines (+11/-0) 2 files modified
src/maasserver/models/node.py (+3/-0) src/maasserver/models/tests/test_node.py (+8/-0) |
||||
To merge this branch: | bzr merge lp:~julian-edwards/maas/mark-failed-twice | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | Approve | ||
Review via email: mp+234410@code.launchpad.net |
Commit message
If Node.mark_failed() is called when the node is already in a failed state, ignore it.
Description of the change
This could be seen as papering over an underlying problem and I won't disagree with that, but this is not a bad thing to do anyway.
To post a comment you must log in.
I think you're doing the right thing. A second mark-as-failed might come from a concurrent job, such as the power poller.