Merge lp:~julian-edwards/maas/help-in-footer into lp:~maas-committers/maas/trunk

Proposed by Julian Edwards
Status: Merged
Approved by: Julian Edwards
Approved revision: no longer in the source branch.
Merged at revision: 479
Proposed branch: lp:~julian-edwards/maas/help-in-footer
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 27 lines (+5/-1)
2 files modified
src/maasserver/static/css/modifiers.css (+3/-0)
src/maasserver/templates/maasserver/base.html (+2/-1)
To merge this branch: bzr merge lp:~julian-edwards/maas/help-in-footer
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+102423@code.launchpad.net

Commit message

Put a link to the help wiki in the page footer.

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Nice example in the diff context of why double-spacing after a full stop is not obsolete after all: “© 2012 Canonical Ltd. Ubuntu and Canonical are registered trademarks of Canonical Ltd.” — there's no way for any software that's rendering this text to figure out on its own that that first “Ltd.” ends in a full stop. Not even if it knows that Ltd. is an abbreviation; not reliably by looking at capitalization of the next word, because the next word is a proper name. It could use LaTeX's algorithm (capitalization of the last letter before the dot), but then it would get any other usage of Ltd. wrong. In fact even as a human I find this case quite difficult.

Revision history for this message
Jeroen T. Vermeulen (jtv) :
review: Approve
Revision history for this message
Julian Edwards (julian-edwards) wrote :

I agree! Double space forevah.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/maasserver/static/css/modifiers.css'
2--- src/maasserver/static/css/modifiers.css 2012-04-05 06:23:59 +0000
3+++ src/maasserver/static/css/modifiers.css 2012-04-18 02:44:19 +0000
4@@ -41,6 +41,9 @@
5 .space-right-small {
6 margin-right: 10px;
7 }
8+.space-left-small {
9+ margin-left: 10px;
10+ }
11 .space-bottom-none {
12 margin-bottom: 0;
13 }
14
15=== modified file 'src/maasserver/templates/maasserver/base.html'
16--- src/maasserver/templates/maasserver/base.html 2012-04-06 14:48:18 +0000
17+++ src/maasserver/templates/maasserver/base.html 2012-04-18 02:44:19 +0000
18@@ -107,7 +107,8 @@
19 <img src="{{ STATIC_URL }}img/ubuntu_logo_footer.png" alt="Ubuntu" />
20 {% block footer-copyright %}
21 <p>&copy; 2012 Canonical Ltd. Ubuntu and Canonical are registered
22- trademarks of Canonical Ltd.</p>
23+ trademarks of Canonical Ltd.
24+ <a class="space-left-small" href="https://wiki.ubuntu.com/ServerTeam/MAAS/" target="_blank">View Documentation</a></p>
25 {% endblock %}
26 <div class="clear"></div>
27 </div>