Merge lp:~julian-edwards/maas/doc-improvements into lp:~maas-committers/maas/trunk

Proposed by Julian Edwards
Status: Merged
Approved by: Julian Edwards
Approved revision: no longer in the source branch.
Merged at revision: 1542
Proposed branch: lp:~julian-edwards/maas/doc-improvements
Merge into: lp:~maas-committers/maas/trunk
Diff against target: 75 lines (+27/-7)
3 files modified
docs/about.rst (+14/-2)
docs/juju-quick-start.rst (+12/-4)
docs/troubleshooting.rst (+1/-1)
To merge this branch: bzr merge lp:~julian-edwards/maas/doc-improvements
Reviewer Review Type Date Requested Status
Jeroen T. Vermeulen (community) Approve
Review via email: mp+178654@code.launchpad.net

Commit message

Fix some problems in the documentation;
 - Correct references to filing bugs and contacting the team
 - How to contribute to documentation
 - Correct juju environments.yaml
 - wrong package name on dpkg-reconfigure

To post a comment you must log in.
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Nice polish, thanks. Some notes as you'd expect:

docs/about.rst...

19 +If you see something wrong with this documentation, you can fix it by
20 +downloading the source to MAAS by following the instructions in :doc:`the
21 +hacking guide <hacking>` and proposing a merge against lp:maas on
22 +Launchpad. The documentation source lives in the top-level ``doc/`` directory.

That's a bit much for one sentence: "you can fix problems by downloading the source by following the downloading and hacking instructions and proposing a merge." Note two levels of "by." I would suggest shorter sentences:

    If you see something wrong with this documentation, you can help us
    fix it. Download the source to MAAS following the instructions in
    :doc:`the hacking guide <hacking>`, make your changes, and propose a
    merge against lp:maas on Launchpad.

docs/juju-quick-start.rst...

36 +**Note**: You do not need to use the MAAS web UI or API to pre-allocate
37 +a node to yourself, Juju will do this for you.

The "pre-allocate" makes this very specific to what you think the reader might be thinking. I find it a bit confusing from the perspective of a reader who isn't making that mistake: "pre-allocate? Why would I want to pre-allocate? Isn't regular allocation enough?"

I'd just say "allocate" there.

Also in docs/juju-quick-start.rst...

52 Substitute the API key from earlier into the ``${maas-api-key}``
53 +slot, and the hostname of your MAAS server into the ``${my-maas-server}``
54 slot.

The <random string here> may also need explaining, if only to give the user a bit of confidence that we really do mean a random string, and this isn't some kind of l33t-speak placeholder for something we meant to document later. Maybe use the same notation that you also used for these other substitutions? Or would that become too involved?

review: Approve
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Cheers, all good points. It seems
that while I can proof-read others',
I am useless at proof-reading my
own prose!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'docs/about.rst'
2--- docs/about.rst 2012-11-20 21:46:37 +0000
3+++ docs/about.rst 2013-08-06 05:40:36 +0000
4@@ -31,5 +31,17 @@
5
6 If you have some extra information to add, or think you have spotted
7 an error or something out of date, we really want to hear about
8-it. File a bug report or contact us via the MAAS homepage at
9-http://maas.ubuntu.com
10+it. Please `File a bug report`_ or `contact us directly`_. In addition
11+you can talk to us on the Freenode IRC channel #maas.
12+
13+.. _File a bug report:
14+ https://bugs.launchpad.net/maas/+filebug
15+
16+.. _contact us directly:
17+ https://launchpad.net/~maas-maintainers/+contactuser
18+
19+If you see something wrong with this documentation, you can help us fix it.
20+Download the source to MAAS by following the instructions in
21+:doc:`the hacking guide <hacking>`, make your changes, and propose a merge
22+against lp:maas on Launchpad. The documentation source lives in the top-level
23+``doc/`` directory.
24
25=== modified file 'docs/juju-quick-start.rst'
26--- docs/juju-quick-start.rst 2013-06-05 10:44:25 +0000
27+++ docs/juju-quick-start.rst 2013-08-06 05:40:36 +0000
28@@ -21,8 +21,11 @@
29 One hard and fast rule is that you'll need to use a different API key
30 for each Juju *environment* you set up within a single MAAS cluster.
31
32-You'll also need to add an SSH key to MAAS so that you, and Juju, can
33-SSH into freshly provisioned machines.
34+There is no need to explicitly add an SSH key to MAAS when using Juju;
35+it will automatically put your public key on any hosts that it starts up.
36+
37+**Note**: You do not need to use the MAAS web UI or API to allocate
38+a node to yourself, Juju will do this for you.
39
40
41 Getting a key
42@@ -59,13 +62,18 @@
43 environments:
44 maas:
45 type: maas
46- maas-server: 'http://localhost/MAAS'
47+ maas-server: 'http://${my-maas-server}:80/MAAS'
48 maas-oauth: '${maas-api-key}'
49- admin-secret: 'nothing'
50+ admin-secret: ${your-admin-secret}
51+ default-series: precise
52
53 Substitute the API key from earlier into the ``${maas-api-key}``
54+slot, and the hostname of your MAAS server into the ``${my-maas-server}``
55 slot.
56
57+The ``${your-admin-secret}`` slot should be replaced with a random pass-phrase,
58+there is no default.
59+
60
61 Now Juju
62 --------
63
64=== modified file 'docs/troubleshooting.rst'
65--- docs/troubleshooting.rst 2013-06-07 16:26:25 +0000
66+++ docs/troubleshooting.rst 2013-08-06 05:40:36 +0000
67@@ -98,7 +98,7 @@
68 If you made a mistake during setup or you just need to reconfigure your MAAS
69 server, you can simply run the setup again:
70
71- ``sudo dpkg-reconfigure maas``
72+ ``sudo dpkg-reconfigure maas-region-controller``
73
74
75 **Can't find MAAS webpage**