Merge lp:~julian-edwards/maas/doc-improvements into lp:~maas-committers/maas/trunk
Proposed by
Julian Edwards
Status: | Merged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Approved by: | Julian Edwards | ||||||||
Approved revision: | no longer in the source branch. | ||||||||
Merged at revision: | 1542 | ||||||||
Proposed branch: | lp:~julian-edwards/maas/doc-improvements | ||||||||
Merge into: | lp:~maas-committers/maas/trunk | ||||||||
Diff against target: |
75 lines (+27/-7) 3 files modified
docs/about.rst (+14/-2) docs/juju-quick-start.rst (+12/-4) docs/troubleshooting.rst (+1/-1) |
||||||||
To merge this branch: | bzr merge lp:~julian-edwards/maas/doc-improvements | ||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeroen T. Vermeulen (community) | Approve | ||
Review via email: mp+178654@code.launchpad.net |
Commit message
Fix some problems in the documentation;
- Correct references to filing bugs and contacting the team
- How to contribute to documentation
- Correct juju environments.yaml
- wrong package name on dpkg-reconfigure
To post a comment you must log in.
Nice polish, thanks. Some notes as you'd expect:
docs/about.rst...
19 +If you see something wrong with this documentation, you can fix it by
20 +downloading the source to MAAS by following the instructions in :doc:`the
21 +hacking guide <hacking>` and proposing a merge against lp:maas on
22 +Launchpad. The documentation source lives in the top-level ``doc/`` directory.
That's a bit much for one sentence: "you can fix problems by downloading the source by following the downloading and hacking instructions and proposing a merge." Note two levels of "by." I would suggest shorter sentences:
If you see something wrong with this documentation, you can help us
fix it. Download the source to MAAS following the instructions in
:doc:`the hacking guide <hacking>`, make your changes, and propose a
merge against lp:maas on Launchpad.
docs/juju- quick-start. rst...
36 +**Note**: You do not need to use the MAAS web UI or API to pre-allocate
37 +a node to yourself, Juju will do this for you.
The "pre-allocate" makes this very specific to what you think the reader might be thinking. I find it a bit confusing from the perspective of a reader who isn't making that mistake: "pre-allocate? Why would I want to pre-allocate? Isn't regular allocation enough?"
I'd just say "allocate" there.
Also in docs/juju- quick-start. rst...
52 Substitute the API key from earlier into the ``${maas-api-key}`` maas-server} ``
53 +slot, and the hostname of your MAAS server into the ``${my-
54 slot.
The <random string here> may also need explaining, if only to give the user a bit of confidence that we really do mean a random string, and this isn't some kind of l33t-speak placeholder for something we meant to document later. Maybe use the same notation that you also used for these other substitutions? Or would that become too involved?